Add documentation warning about pickled data about typed-argument-parser HOT 4 CLOSED

@martinjm97 I think a warning in the readme would suffice. Just something eye catching since the note about pickling kind of easy to miss and requires the user to already know the security risk about unpickling data. Something like this at the top of the readme section for load:

❗ ⚠️
Never call args.load('args.json') on untrusted files. Argument loading uses the pickle module to decode complex types automatically. Unpickling of untrusted data is a security risk and can lead to arbitrary code execution. See the warning in the pickle docs
❗ ⚠️

Feel free to merge #82 if that sounds fine.

from typed-argument-parser.

Alternatively, the load method could refuse to unpickle data by default unless a keyword argument data_is_trusted is set to true. This would make the warning a lot easier to notice. But it would be backwards incompatible, so perhaps that's overkill.

from typed-argument-parser.

Hi @Cnoor0171,

Thank you for identifying this security risk. Would you be satisfied by a change to the readme? If so, we're happy to look over a PR and we'll try to get to it soon.

Thanks again,
Kyle and Jesse

from typed-argument-parser.

Thank you for keeping a watchful eye out wrt security. Much appreciated!

--Jesse

from typed-argument-parser.