IE9 shapes about svg.js HOT 11 CLOSED

When doing a checkup yesterday I noticed this too. It's something recent I suspect. IE10 does a wonderful job so it's most definitely a render bug in IE9.

from svg.js.

Did it at a point work in IE9? I might browse through the commit history to pinpoint the source of issue. Good thing IE9 has such good developer tools</sarcasm>.

from svg.js.

Yes it did. But to be honest, I only test regularly on IE10 because that is the one I have easily available. I'll go down in history later this week to find our where it went wrong.

from svg.js.

But if you are willing to take the dive, any help would be very welcome. :) I don't have a lot of time on my hands right now and when I know where it went wrong I can fix it quickly.

from svg.js.

I'll try and look. I need to fix IE9 as soon as possible in order to
know whether I can continue using svg.js, which I dig ;)

On 3.7.2013 20:26, Wout Fierens wrote:

But if you are willing to take the dive, any help would be very
welcome. :) I don't have a lot of time on my hands right now and when
I know where it went wrong I can fix it quickly.

—
Reply to this email directly or view it on GitHub
#57 (comment).

from svg.js.

Brilliant! I need the fix too next week so if you don't manage to find it I will continue the search this weekend. It probably is a small thing but unfortunately it really is like finding a needle in a haystack. ;)

Great to hear you like svg.js.

from svg.js.

Tried to run the specs in IE9 and got a sad image. That'll be a one-liner somewhere imho

from svg.js.

Yes, most definitely. Probably an IE incompatibility in SVG.Number. IE 10 also throws a lot of errors, altough they are more related to different output formatting, nothing to worry about:

I'll fix that today.

from svg.js.

A new version is on the way, IE9-proof. It turned out to be something very silly. As it turns out, IE9 does not call toString() on objects when passing an object as attribute value. Changing lines 166 and 167 in the src/element.js from this:

n != null ?
  this.node.setAttributeNS(n, a, v) :
  this.node.setAttribute(a, v)

to this:

n != null ?
  this.node.setAttributeNS(n, a, v.toString()) :
  this.node.setAttribute(a, v.toString())

Will fix the problem. I will release the changes later today.

from svg.js.

Yes that did it, thanks. Great work!

from svg.js.

Release v0.26 has been released fixing IE9 issues.

from svg.js.