Comments (4)
sverweij
commented on July 28, 2024
1
Thanks for raising this!
This needs to be fixed indeed. Probably using `path.possix` instead of
`path` for representations of path within dependency-cruiser code will
resolve the lion's share of this issue.
I'll pick it up in the coming day(s).
โฆOn Thu, Jan 11, 2018 at 11:11 AM Fabian Keller ***@***.***> wrote:
On Windows, dependency-cruiser extracts all modules and dependencies with
backslashes \ in their names instead of forward slashes /. The
backslashes are even shown in the HTML tables generated by the HTML
reporter.
The main problem is that the default rules don't match backslashes as they
are written with forward slashes. Thus, the rules cannot be written
platform-agnostic.
Expected Behavior
dependency-cruiser should always use forward slashes.
Possible Solution
Maybe convert all backslashes to forward slashes?
Steps to Reproduce (for bugs)
On windows:
$ depcruise --validate .dependency-cruiser.json src
error some-rule: src\cli.ts โ src\content\entry\index.ts
...
Context
Development on Windows, CI/CD on Linux. I'd love to use dependency-cruiser
without any changes on both platforms.
Your Environment
- Version used: 2.10.1
- Node version: 8.9.2
- Operating System and version: Win10
โ
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#27>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AEmWRSlxJ-PeZ4xdTEFQsMUe7mgiZ5BPks5tJd46gaJpZM4RammV>
.
from dependency-cruiser.
sverweij
commented on July 28, 2024
1
hi @FaKeller - I've published [email protected]
- it works consistently on win32 and posix platforms.
- in a few corner cases it doesn't yet on win32. I want to solve them before release 2.11.0, but it's not likely you'll bump into them
- windows extended length paths don't resolve back to files on disk from the internal representation
- neither do paths with non-ascii characters (
C:\\ๅบๅๅ\\ๅฎๅ จ็ไบคไบ.js) - the internal API doesn't handle basePaths correctly on win32. Only occurs if you access the API directly as the command line interface doesn't expose basePath as a parameter (yet)
=> If you want to, you can give it a spin. I'm curious about any feedback you'd have.
(I'll keep working on it in the mean time)
from dependency-cruiser.
FaKleiser
commented on July 28, 2024
I just tried it and it works great! ๐๐๐ And as the rules work now I already spotted a bug ๐ Thank you for making this great tool!
from dependency-cruiser.
sverweij
commented on July 28, 2024
Good to hear it works well for you! (And thanks for the compliment ๐ ).
PR #29 is merged and is released on npmjs as version 2.11.0. Besides the cross platform support you've tested, the new release will handle corner cases mentioned above:
- windows extended length paths and non-ascii paths work
- basePaths passed to the internal API work 100% correct on win32 as well.
from dependency-cruiser.
Related Issues (20)
- Issue: numberOfDependentsLessThan does not calculate dependents properly when index.ts is used inbetween HOT 5
- Feature request: Allow to have rules checking Typescript types but also rules that ignore Typescript types HOT 2
- Issue: false positive for couldNotResolve for type only package HOT 5
- Question: A dependency view of each "TYPE" or "INTERFACE" HOT 3
- Question: monorepo, combinedDependencies & not-dev-dep HOT 2
- Error: No "exports" main defined in <project_name>/node_modules/dependency-cruiser/package.json HOT 3
- What am I missing about rcdot? "'rcdot' is not a valid output type" HOT 2
- Issue: not-to-unresolvable return error when using typescript alias in module project HOT 2
- Why doesn't dependency-cruiser "ignore" my private-registry package like it does with node-modules? HOT 6
- Q: Dep Graph for each file HOT 3
- Feature request: consider symlinked workspaces HOT 5
- Issue: not-to-spec and not-to-dev-dep default config should include tsx and jsx HOT 3
- Issue: using `workspace:` to implement nohoist in a package.json while using pnpm throws an error HOT 4
- Missing mermaid example HOT 1
- Feature request: reporters might report `comment` of rules other than `forbidden` HOT 3
- Issue: cruise API - breaking changes HOT 4
- Question: Resolving typescript source files imported from outside specified package HOT 2
- Question: dependency-cruiser API gives a different result when `baseDir` is changed HOT 6
- Question: Can I access the classes/methods/functions in modules? HOT 4
- Listing dependancy tree via dependency-cruiser gives me the reference from barel files HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-cruiser.