Code Monkey home page Code Monkey logo

Comments (6)

svenstaro avatar svenstaro commented on May 23, 2024

This should now all be fixed, please check.

from upload-release-action.

shawaj avatar shawaj commented on May 23, 2024

@ggreif do you mean that all three lines below can be removed from the readme?

          r="${r//'%'/'%25'}"                               # Multiline escape sequences for %
          r="${r//$'\n'/'%0A'}"                             # Multiline escape sequences for '\n'
          r="${r//$'\r'/'%0D'}"

from upload-release-action.

ggreif avatar ggreif commented on May 23, 2024

@shawaj

@ggreif do you mean that all three lines below can be removed from the readme?

          r="${r//'%'/'%25'}"                               # Multiline escape sequences for %
          r="${r//$'\n'/'%0A'}"                             # Multiline escape sequences for '\n'
          r="${r//$'\r'/'%0D'}"

Turns out you can't. I had to revert my other change. But now I have filed a PR to check whether multi-line strings arrive properly in the release. (You have to allow the CI.) I have seen it leaving %0A in the body and not converting those back to newlines (this was with @v2, I wonder if 2.4.0 behaves the same).

from upload-release-action.

shawaj avatar shawaj commented on May 23, 2024

@ggreif latest @v2 should be the same as v2.4.0 as it's tagged as such https://github.com/svenstaro/upload-release-action/releases/tag/v2

And

https://github.com/svenstaro/upload-release-action/releases/tag/2.4.0

But depends whether you ran that within the last 2 weeks since v2.4.0 was released

from upload-release-action.

ggreif avatar ggreif commented on May 23, 2024

@ggreif latest @v2 should be the same as v2.4.0 as it's tagged as such https://github.com/svenstaro/upload-release-action/releases/tag/v2

And

https://github.com/svenstaro/upload-release-action/releases/tag/v2.4.0

But depends whether you ran that within the last 2 weeks since v2.4.0 was released

I guess that should be https://github.com/svenstaro/upload-release-action/releases/tag/2.4.0

Nope, I run the action lats time in December.

from upload-release-action.

shawaj avatar shawaj commented on May 23, 2024

Oops yes that was a typo sorry

from upload-release-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.