Comments (7)
Hm, this
return function ModalComponent(anchor, props2) {
return Component(
anchor,
{
...props,
...props2,
});
};
doesn't cause double mounting.
If you do manual mounting, it's your responsibility to do manual unmounting. It just happened that at some points, Svelte sweeps away your manually mounted Popups. You can confirm this by adding an onDestroy logger to the Popup - it never logs in your REPL.
from svelte.
duplicate of #11973
from svelte.
duplicate of #11973
I agree
But this problem is cause svelte mount.
#11973 is svelte fade
from svelte.
Locally, I enabled legacy.componentApi
and modified the code to
return function ModalComponent(anchor, props_) {
let options = props_ ? {
target: anchor.nodeType == 8 ? anchor.parentNode : anchor,
props: props_,
} : anchor;
return new Component({
...options,
props: {
...props,
...options.props,
},
});
And it still does double mounting. Well, under the hood, it still uses mount()
.
Also, for some reason, with enabled it tries to mount to a comment node :Dlegacy.componentApi
from svelte.
thanks!!
from svelte.
As pointed out, adjusting the generated code will resolve the issue. The problem was that calling mount
was wrong in this instance, because the component is rendered by the framework, not instantiated manually. What the bind method does is decorate the component. here's the fixed playground.
Therefore closing.
Note this is all deep into advanced Svelte territory, so it's totally understandable that it's not easy to grasp right away.
from svelte.
I just looked at the document, but it seems like something is very different. Thank you very much.
from svelte.
Related Issues (20)
- Svelte 5: next 182 breaks Threlte apps HOT 2
- Svelte 5: Regression since 5.0.0-next.171 HOT 4
- Rerendering bug in table with sticky first column HOT 2
- Svelte 5: Usage of `$effect.active` in `.svelte.js` files gives incorrect error in runtime HOT 2
- Svelte 5: Rune to Store and vice versa HOT 3
- Svelte 5: decide on behaviour of `$state.frozen` HOT 20
- Reactivity regression since 5.0.0-next.177 HOT 6
- Error on mounting to detached element with `css: injected` HOT 2
- Animation is not applied inside nested global css selector HOT 5
- svelte 5 : structural clone failed HOT 2
- `list` is not reactive, but `list.length` is HOT 11
- Svelte 5: Portal'd content and multiple elements in same conditional HOT 3
- `SvelteDate.now()` as a live updating source HOT 6
- `<svelte:component>` wrong error message on component creation HOT 2
- Children duplication of list items rendered within components after v `5.0.0-next.179`
- Svelte 5: cannot change nested objects if not binded HOT 25
- [Svelte 5] `state_unsafe_mutation` when using class getters that perform side effects HOT 3
- Svelte 5: using inlang Paraglide JS message in <svelte:head> meta description tag causes error in SSR
- Rest parameters in a snippet should be a compile error HOT 2
- svelte 5 : Attribute values containing `{...}` must be enclosed in quote marks, unless the value only contains the expression
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svelte.