Describe the bug When I deploy my project on Vercel, this line giv

Isn't it already populated here? <div

event.platform is undefined when deploying on Vercel,about sveltejs/kit

dummdidumm commented on September 13, 2024 1

What are you using platform for? It's only defined for edge functions, because its only member, context, is only available within edge functions (settable through the runtime adapter option). The only member of context is waitUntil, which you can now import directly in both edge and serverless functions: https://vercel.com/changelog/waituntil-is-now-available-for-vercel-functions

@Rich-Harris should we "shim" this for serverless, by passing along a "fake" context on which we provide the waitUntil method? I tend towards "no, use the package Vercel provides directly". If you're using platform you're already provider-specific.

from kit.

dummdidumm commented on September 13, 2024 1

Ok, so the recommended approach is to import it from here import { waitUntil } from '@vercel/functions'?

Exactly

I'm not sure why, but I was under the impression that such thing should live on the "platform"

platform is more for things that are per-request and coming from the underlying platform. But yeah it's not very strict what's coming from where. In this case, since Vercel provides it, it's better to use the package directly.

For consistency it might even be better to remove it from edge functions? (deprecate with warning first, obvs)

Makes sense

from kit.

alexbjorlig commented on September 13, 2024

What are you using platform for? It's only defined for edge functions, because its only member, context, is only available within edge functions. The only member of context is waitUntil, which you can now import directly in both edge and serverless functions: https://vercel.com/changelog/waituntil-is-now-available-for-vercel-functions

@Rich-Harris should we "shim" this for serverless, by passing along a "fake" context on which we provide the waitUntil method? I tend towards "no, use the package Vercel provides directly". If you're using platform you're already provider-specific.

It was exactly waitUntil. Ok, so the recommended approach is to import it from here import { waitUntil } from '@vercel/functions'?

I'm not sure why, but I was under the impression that such thing should live on the "platform", but importing from @vercel/functions would also be ok.

from kit.

Rich-Harris commented on September 13, 2024

I tend towards "no, use the package Vercel provides directly"

I lean the same way - it would just add code to people's bundles if they weren't using it. For consistency it might even be better to remove it from edge functions? (deprecate with warning first, obvs)

from kit.

eltigerchino commented on September 13, 2024

Isn't it already populated here?

kit/packages/adapter-vercel/files/edge.js

Lines 13 to 24 in f67898d

    
           export default async (request, context) => { 
        
           	await initialized; 
        
           	return server.respond(request, { 
        
           		getClientAddress() { 
        
           			return /** @type {string} */ (request.headers.get('x-forwarded-for')); 
        
           		}, 
        
           		platform: { 
        
           			context 
        
           		} 
        
           	}); 
        
           };

The ambient type for it exists too although it's not correctly included when importing the adapter at the moment.

kit/packages/adapter-vercel/ambient.d.ts

Lines 1 to 12 in f67898d

    
           import { RequestContext } from './index.js'; 
        
           declare global { 
        
           	namespace App { 
        
           		export interface Platform { 
        
           			/** 
        
           			 * `context` is only available in Edge Functions 
        
           			 */ 
        
           			context?: RequestContext; 
        
           		} 
        
           	} 
        
           }

Or am I mistaken and thinking of something entirely different?

from kit.

dummdidumm commented on September 13, 2024

It's there, but it's only set for edge functions, not serverless functions, hence the confusion and thought to remove the context for edge, since it only contains waitUntil. Argument against it is that at some point in the future there might be other things on the context object and we would go adding it back in again - which makes me think we just leave everything as is and close this issue.

from kit.

event.platform is undefined when deploying on Vercel about kit HOT 6 OPEN

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	export default async (request, context) => {
	await initialized;

	return server.respond(request, {
	getClientAddress() {
	return /** @type {string} */ (request.headers.get('x-forwarded-for'));
	},
	platform: {
	context
	}
	});
	};

	import { RequestContext } from './index.js';

	declare global {
	namespace App {
	export interface Platform {
	/**
	* `context` is only available in Edge Functions
	*/
	context?: RequestContext;
	}
	}
	}