Macro for identifying work vs personal email addresses about dbt_census_utils HOT 5 CLOSED

@Stephen986 I think if we create a seed file for free domain provider, then anyone who wants to use our project will have to do a dbt seed before using our macro. I think in any of the projects that we have gone thru, we are not using a database object to run the macro. I think maybe we should keep it in separate macro file itself which returns the list.

from dbt_census_utils.

@amittiwari1979 I discussed this with you and then Jeff @ Census yesterday. Here's the recap:

1. Requiring people to use 'dbt seed' is fine. We'll just add that to the documentation as something you have to do after dbt deps.
2. Jeff's preference is that the seed files get built in the user's regular seed file directory. We'll have to test what happens when a package doesn't specify where the seed files go! If they're going in the regular seed file directory, I think the files themselves should be prefaced with census_ so it's easy to distinguish them.

from dbt_census_utils.

@amittiwari1979 this macro gets the following error in Snowflake:
Database Error in model test_is_personal_email (models/test_is_personal_email.sql)
16:29:19 001003 (42000): SQL compilation error:
16:29:19 syntax error line 10 at position 99 unexpected 'unnest'.
16:29:19 syntax error line 10 at position 105 unexpected '('.
16:29:19 compiled Code at target/run/census_utils_integration_tests/models/test_is_personal_email.sql

from dbt_census_utils.

Also, is there a reason you're doing an array_agg and then a get_single_value for this macro rather than doing
dbt_utils.get_column_values(table=ref('free_email_providers'), column='email_domains')? That seems to get the same results with less code.

from dbt_census_utils.

r

@Stephen986 Yeah, the macro is working same with lesser code. I have updated it in Parse GA4 Client Id PR.

from dbt_census_utils.