stage1 passes silently though populate fails about deepsea HOT 4 CLOSED

This case arose because salt had permission to read only one of the devices
(which was supposed to be the osd) and the other devices were not having permissions to read by hwinfo, I'm not sure whether someone will create fine grained permissions like that, but if they do we raise an exception if certain fields of hwinfo are not populated instead of passing through and dropping the device from the list

from deepsea.

Can we close this @theanalyst ?

from deepsea.

Not sure whether relevant but we do fail when we don't have permissions to read a device instead of skipping it, not sure whether this might come up in prod. scenarios

from deepsea.

I did this here:

https://github.com/SUSE/DeepSea/blob/master/srv/salt/_modules/cephdisks.py#L399

Still, I can't recall if Exceptions raised by a module will be passed through if the module is invoked by a runner, like in our case.

salt-run populate.proposals

@theanalyst any chance to reproduce this with one of the later versions?

from deepsea.