Code Monkey home page Code Monkey logo

Comments (5)

BlaineEXE avatar BlaineEXE commented on May 23, 2024

While searching around the internet for this, I can't find any usage of NTP_FORCE_SYNC_ON_STARTUP that isn't SUSE-related. So we don't risk breaking NTP on non-suse linuxes, it would seem appropriate to gate this behind an OS check, yes?

{% if salt['grains.get']('os_family').lower() == 'suse' %}
    # set NTP_FORCE_SYNC_ON_STARTUP
{% endif %}

from deepsea.

swiftgist avatar swiftgist commented on May 23, 2024

Sounds fine. Grains are directly accessible from Jinja:

{% if grains['os_family'] == 'Suse' %}
{% if grains['os'] == 'SUSE' %}

I believe this will be the only use case in the sls file. If CentOS, Ubuntu, etc. need similar settings and the Jinja is starting to overtake the file, then a module may be the way to go. That can wait though until the need arises.

from deepsea.

jan--f avatar jan--f commented on May 23, 2024

I wonder how much we'll gain from this. If ntp is setup properly we won't have to sync on startup. Since this seems to be suse specific, I'd be in favour of not doing it.

from deepsea.

BlaineEXE avatar BlaineEXE commented on May 23, 2024

As it seems to be (1) SUSE specific and (2) only 'maybe' improves deployment speed, I think this is something that we should at least table for later, though I'm not against closing this as an unaccepted feature.

from deepsea.

jan--f avatar jan--f commented on May 23, 2024

Yep I agree. I'll close this for now. We can always revisit if the need arises.

from deepsea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.