Comments (5)
While searching around the internet for this, I can't find any usage of NTP_FORCE_SYNC_ON_STARTUP
that isn't SUSE-related. So we don't risk breaking NTP on non-suse linuxes, it would seem appropriate to gate this behind an OS check, yes?
{% if salt['grains.get']('os_family').lower() == 'suse' %}
# set NTP_FORCE_SYNC_ON_STARTUP
{% endif %}
from deepsea.
Sounds fine. Grains are directly accessible from Jinja:
{% if grains['os_family'] == 'Suse' %}
{% if grains['os'] == 'SUSE' %}
I believe this will be the only use case in the sls file. If CentOS, Ubuntu, etc. need similar settings and the Jinja is starting to overtake the file, then a module may be the way to go. That can wait though until the need arises.
from deepsea.
I wonder how much we'll gain from this. If ntp is setup properly we won't have to sync on startup. Since this seems to be suse specific, I'd be in favour of not doing it.
from deepsea.
As it seems to be (1) SUSE specific and (2) only 'maybe' improves deployment speed, I think this is something that we should at least table for later, though I'm not against closing this as an unaccepted feature.
from deepsea.
Yep I agree. I'll close this for now. We can always revisit if the need arises.
from deepsea.
Related Issues (20)
- make install fails on archlinux HOT 1
- cephdisks.unused falsely returns mounted disks
- Typo - should be c_v_commands instead of d_v_commands
- Example code for return structures of modules HOT 6
- rebuild runner needs to read error messages from osd.py(runner) HOT 2
- osd.remove fails to zap devices on ceph version 14.2.3-349 HOT 10
- functests.3nodes fails with IndexError HOT 4
- How to deploy /dev/sdb ,/dev/sdc only use /dev/nvme0n1 as db device ? HOT 5
- Can not remove cluster node HOT 2
- [SES5] remove.osd functest fails HOT 9
- No role for rbd-client (e.g. mapping images) HOT 1
- Stage.3 Hang in Disks.Deploy HOT 6
- IGW lrbd support
- Device discovery not working in KVM environment HOT 3
- SES5: "time_init: ntp" does not work as expected HOT 1
- SES5: osd.redeploy fails for filestore -> bluestore
- deepsea hangs in stage 3 @ ceph.mgr.auth on
- deepsea monitor not working with gitfs
- stage.0 Exception: 'getpwuid(): uid not found:
- Deepsea development status after cephadm release HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deepsea.