Bug: Type mismatch in geometries about surrealdb.js HOT 5 CLOSED

I think the confusion is happening because what SurrealDB represents as a line (two points) is actually a linestring (two or more points). They're different datatypes, but we just simply use only linestrings.

from surrealdb.js.

This test might be more straightforward in terms of semantics:

Deno.test("issue #263", async () => {
	const surreal = await createSurreal();

	const input = new GeometryPolygon([
		new GeometryLine([
			new GeometryPoint([1, 2]),
			new GeometryPoint([3, 4]),
		]),
		new GeometryLine([
			new GeometryPoint([5, 6]),
			new GeometryPoint([7, 8]),
		]),
	]);
	const [output, expected] = await surreal.query<[
		typeof input,
		GeometryPolygon,
	]>(
		/* surql */ `
			$input;
			{
				type: "Polygon",
				coordinates: [
					[ [1, 2], [3, 4] ],
					[ [5, 6], [7, 8] ],
				],
			};
		`,
		{ input },
	);

	assertInstanceOf(expected, GeometryPolygon);

	const expectedJson = JSON.parse(JSON.stringify(expected));

	assertEquals(expectedJson, {
		type: "Polygon",
		coordinates: [
			[["1", "2"], ["3", "4"], ["1", "2"]],
			[["5", "6"], ["7", "8"], ["5", "6"]],
		],
	});
	assertEquals(JSON.parse(JSON.stringify(output)), expectedJson);

	await surreal.close();
});

P.S: The test results are the same.

from surrealdb.js.

Hey @tai-kun, I'm not sure if I understand the issue correctly. In the second assertion, only in the test, your added a third point in the lines of the polygon, but you have not added those third points anywhere else. In that sense it's expected that the test fails, right?

from surrealdb.js.

Ah it's just the type that's incorrect! The test you added here threw me off a bit 😅

from surrealdb.js.

I'm sorry for the confusion. I couldn't figure out a good way to reproduce the inconsistency between the type and the actual value. I attempted to recreate it by exploiting the Geo crate to add a GeometryPoint to a GeometryLine in specific cases, but it was a desperate attempt. Please discard that test...

from surrealdb.js.