Unable to call `send_update` about surface HOT 8 CLOSED

Hi @miguel-s!

Ideally, it shouldn't be necessary to pass it manually. The :__surface__ assign belongs to the private API. I'll create a test for this case so we can work on a proper solution.

Cheers.

from surface.

To clarify, this isn't blocking. Since the target changes in live view, you can work around this easily by creating a handle_event/3 in your modal component, and then targeting that component with a phx-click & phx-target on your button.

def handle_event("open", _data, socket) do
  {:noreply, assign(socket, open: true)}
end

from surface.

Hi @cadebward!

I was able to reproduce it. I'll push a fix for it soon.

Thanks for the report.

from surface.

@cadebward!

Actually I can't reproduce it :)

I found another edge case which is when the content of the dialog is empty but that raise another error. What changes should I make in the Dialog demo to raise the same error?

Is the demo not working at all in your tests? Does it work if you use this branch? https://github.com/msaraiva/surface/tree/ms-context-api

from surface.

Just to clarify, the PR is ready to go. As soon as I update the examples, I'll merge it.

In case you're using contexts, you need to adjust your code to the new API, i.e, you need to declare when using context.

Example for the Form component:

  ...
  property change, :event

  context set form, :form

  def init_context(assigns) do
    opts = [phx_change: assigns.change.name, autocomplete: assigns.autocomplete]
    form = form_for(assigns.for, "#", opts)
    {:ok, form: form}
  end
...

Example for the Field component:

  context set field, :atom, scope: :only_children
  context get form, from: Form

  def init_context(assigns) do
    {:ok, field: String.to_atom(assigns.field)}
  end

and finally, Textinput:

  context get form, from: Form
  context get field, from: Field

Note: end_context/1 is no longer required.

from surface.

Hmm... I wonder if my problem was that I had a custom update/2 function? I'll go ahead and close this since it was easy to work around and you aren't able to reproduce. Thanks for the update.

from surface.

Hi @msaraiva @cadebward!

I'm running into the same issue with send_update. It seems to only occur when I use a custom update/2 function, just as @cadebward suspected.

I found workaround by passing the :__surface__ assign in the send_update function.

from surface.

Hi @msaraiva!

Just want to confirm that #114 fixed this issue for me.
I was still using the v0.1.0-alpha.2 release, but recently upgraded to the master branch.

Thanks!

from surface.