Code Monkey home page Code Monkey logo

Comments (4)

nytamin avatar nytamin commented on July 25, 2024

Thanks for reporting this bug!
It sounds to me like there must be an open handle left somewhere. There are a few tips on how to troubleshoot open handles in this discussion:
https://stackoverflow.com/questions/26057328/node-js-inspect-whats-left-in-the-event-loop-thats-preventing-the-script-from

Feel free to submit a pull request to fix this!

from xkeys.

nytamin avatar nytamin commented on July 25, 2024

Hey @cwilling , I've had a look at the issue you've described.
I've got a fix ready, could you verify if it works for you?

In your devicefinder-repo, make the following changes:

package.json:

"dependencies": {
    "xkeys": "2.1.1-alpha.1

main.js:

// Line 32:
if (!win.isDestroyed()) {
	win.webContents.send("lostDevice", xkeysPanel.devicePath);
}

// Line 101:
app.on('window-all-closed', () => {
	if (process.platform !== 'darwin') {
		watcher.stop()
		.then(() => {
			ipcMain.removeAllListeners();
			app.quit()
		})
		.catch(console.error)
	}
})

I've tried it locally and it seems ok, please let me know if it works properly for you too.

from xkeys.

cwilling avatar cwilling commented on July 25, 2024

After applying the changes above, I can no longer replicate the problem. Consider the fix verified!
Thanks.

from xkeys.

nytamin avatar nytamin commented on July 25, 2024

I've published the fix to version 2.1.1

from xkeys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.