Comments (4)
Thanks for reporting this bug!
It sounds to me like there must be an open handle left somewhere. There are a few tips on how to troubleshoot open handles in this discussion:
https://stackoverflow.com/questions/26057328/node-js-inspect-whats-left-in-the-event-loop-thats-preventing-the-script-from
Feel free to submit a pull request to fix this!
from xkeys.
Hey @cwilling , I've had a look at the issue you've described.
I've got a fix ready, could you verify if it works for you?
In your devicefinder-repo, make the following changes:
package.json:
"dependencies": {
"xkeys": "2.1.1-alpha.1
main.js:
// Line 32:
if (!win.isDestroyed()) {
win.webContents.send("lostDevice", xkeysPanel.devicePath);
}
// Line 101:
app.on('window-all-closed', () => {
if (process.platform !== 'darwin') {
watcher.stop()
.then(() => {
ipcMain.removeAllListeners();
app.quit()
})
.catch(console.error)
}
})
I've tried it locally and it seems ok, please let me know if it works properly for you too.
from xkeys.
After applying the changes above, I can no longer replicate the problem. Consider the fix verified!
Thanks.
from xkeys.
I've published the fix to version 2.1.1
from xkeys.
Related Issues (20)
- setBacklight with 'red' sets blue light on XKE-40 HOT 2
- Log for XKE-128 HOT 1
- Discussion: Major updates to the library HOT 16
- XK-12 Joystick using wrong bits HOT 8
- XK-8 support HOT 15
- Feature: WebHID HOT 1
- Can XKeysWatcher handle existing connections? HOT 2
- Multiple devices HOT 6
- Backlight methods HOT 6
- Help with building HOT 8
- Any known problems with Raspberry Pi? HOT 2
- XKeys.listAllConnectedPanels is not a function HOT 9
- How to dispose of an xkeysPanel? HOT 10
- call a xkeys function out of the watcher HOT 4
- UnhandledPromiseRejectionWarning when watcher fails to open device HOT 1
- npm packages have a lot of 'junk' files HOT 1
- XK-24 EEPROM retaining code? HOT 2
- yarn build-record-test doesn't work in root of repo
- Intermittent "NotAllowedError: Failed to write the report." on Chrome v115+ HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xkeys.