[Bug]: ComposeAuth Google Sign In is triggering automatically on Android about supabase-kt HOT 6 CLOSED

Thank you for reporting this! I'm publishing 2.0.2-dev with a possible fix (~30min). Let me know if that works!

from supabase-kt.

Thank you for reporting this! I'm publishing 2.0.2-dev with a possible fix (~30min). Let me know if that works!

Thank you @jan-tennert, it's working perfectly fine now ✅

from supabase-kt.

Great! One question: Is there a reason you call supabase.auth.signInWith(Google) in these lines:

                is NativeSignInResult.Success -> {
                    coroutineScope.launch {
                        // This code internally just calls supabaseClient.auth.signInWith(Google)
                        viewModel.loginWithGoogle()
                            .onFailure { tr -> googleLoginState = UIState.Error(tr) }
                            .onSuccess { googleLoginState = UIState.Data(Unit) }
                    }
                }

You already get logged in before the success result is emitted to the callback.

from supabase-kt.

Great! One question: Is there a reason you call supabase.auth.signInWith(Google) in these lines:

                is NativeSignInResult.Success -> {
                    coroutineScope.launch {
                        // This code internally just calls supabaseClient.auth.signInWith(Google)
                        viewModel.loginWithGoogle()
                            .onFailure { tr -> googleLoginState = UIState.Error(tr) }
                            .onSuccess { googleLoginState = UIState.Data(Unit) }
                    }
                }

You already get logged in before the success result is emitted to the callback.

Oh okay, I believe I didn't read the documentation carefully. In that case, even better, I can remove that line of code 👍🏻

from supabase-kt.

Great! One question: Is there a reason you call supabase.auth.signInWith(Google) in these lines:

                is NativeSignInResult.Success -> {
                    coroutineScope.launch {
                        // This code internally just calls supabaseClient.auth.signInWith(Google)
                        viewModel.loginWithGoogle()
                            .onFailure { tr -> googleLoginState = UIState.Error(tr) }
                            .onSuccess { googleLoginState = UIState.Data(Unit) }
                    }
                }

You already get logged in before the success result is emitted to the callback.

Oh okay, I believe I didn't read the documentation carefully. In that case, even better, I can remove that line of code 👍🏻

Yes, so Compose Auth automatically signs in with the ID Token received in the Native Auth flow. (So you don't have to do anything) This result is just to let you know that it worked.

from supabase-kt.

Great! One question: Is there a reason you call supabase.auth.signInWith(Google) in these lines:

                is NativeSignInResult.Success -> {
                    coroutineScope.launch {
                        // This code internally just calls supabaseClient.auth.signInWith(Google)
                        viewModel.loginWithGoogle()
                            .onFailure { tr -> googleLoginState = UIState.Error(tr) }
                            .onSuccess { googleLoginState = UIState.Data(Unit) }
                    }
                }

You already get logged in before the success result is emitted to the callback.

Oh okay, I believe I didn't read the documentation carefully. In that case, even better, I can remove that line of code 👍🏻

Yes, so Compose Auth automatically signs in with the ID Token received in the Native Auth flow. (So you don't have to do anything) This result is just to let you know that it worked.

That's awesome!! The library under the hood is doing a lot more than I thought 😂 Many thanks for your hard work 🙌

from supabase-kt.