Error when parsing file with comments (`;;`) about pddl-rs HOT 6 CLOSED

Hey Danny, thanks for the report - that's correct, there is no support for comments yet. I'll see to add them when I find the time for it.

from pddl-rs.

Where would a comment parser fit into this? I assume it would be under parsers/utilities.rs, similar to ws. I am new to nom, having uses pest before, so I am not certain of how a comment parser would be implemented, perhaps something like this?

/// A combinator that takes a parser `inner` and produces a parser that consumes
/// all leading comment characters `;` and the endline char or EOF at the end of
/// the line, returning the outputs of `inner`.
pub fn comment<'a, F, O>(inner: F) -> impl FnMut(Span<'a>) -> ParseResult<'a, O>
where
    F: FnMut(Span<'a>) -> ParseResult<'a, O>,
{
    delimited(many1(char(';')), ws(inner), alt((line_ending, eof)))
}

This seems to work for simple tests with strings like ; content, ;; content, ; content\n, ;content, etc.

However, I am not sure where this would be integrated so that it works throughout the parser, such as in my example above.

Thoughts?

from pddl-rs.

Utilities would be a good spot - I noticed you forked the repo already, but if the tests go through here on GitHub it will be fixed in #82 and I'll release a new version right away.

I had a little argument with nom about this too just now. That both ws and the comment parser would have to ignore spaces, which in turn interfered with space_separated_list1 and the likes.

from pddl-rs.

It's available in 0.0.7 now - could you give it a try and tell me if it checks out?

from pddl-rs.

Works for all examples I was utilizing it for. I really appreciate your swiftness at acknowledging and resolving this issue.

from pddl-rs.

Pleasure! If you can put the library to good use, do tell - I'd be happy to hear your feedback!

from pddl-rs.