Code Monkey home page Code Monkey logo

Comments (11)

sunjw avatar sunjw commented on May 28, 2024

I cannot reproduce the crash.
nocrash

Could you please paste your screenshot?

from jstoolnpp.

NN--- avatar NN--- commented on May 28, 2024

I use x64 build

from jstoolnpp.

sunjw avatar sunjw commented on May 28, 2024

Still no crash found on x64 build @NN---
nocrash x64

Does it crash on other JSON file?

from jstoolnpp.

NN--- avatar NN--- commented on May 28, 2024

Yes

from jstoolnpp.

NN--- avatar NN--- commented on May 28, 2024

UINT wParam, LONG lParam ? :)

Use WPARAM and LPARAM types which are defined correctly for you: https://msdn.microsoft.com/en-us/library/windows/desktop/ms633573(v=vs.85).aspx

Crashes here

LRESULT CALLBACK EditControlEx::EditControlProc(
	HWND hEditControl, UINT message, UINT wParam, LONG lParam)
{
	EditControlEx *pEditControlEx = (EditControlEx *)(::GetWindowLongPtr(hEditControl, GWLP_USERDATA));

	switch (message)
    {
	case WM_KEYDOWN:
		{
			if((::GetKeyState(VK_CONTROL) & 0xFF00) == 0xFF00)
			{
				if(wParam == 'A' || wParam == 'a')  
				{  
					::SendMessage(pEditControlEx->m_hEditControl, EM_SETSEL, 0, -1);
					return TRUE;  
				}  
			}
		}
		break;
	}

	return CallWindowProc( // <<=== HERE
		(WNDPROC)pEditControlEx->m_oldEditControlProc, 
		hEditControl, message, wParam, lParam);
}

from jstoolnpp.

sunjw avatar sunjw commented on May 28, 2024

OK, thanks for the fix. I just merge it.

from jstoolnpp.

sunjw avatar sunjw commented on May 28, 2024

Fixed with dae70b8

from jstoolnpp.

sunjw avatar sunjw commented on May 28, 2024

Hi, @NN---
Would you like to try this build and see if any crash happens?

JSMinNPP.dll

(Not an png, just to allow Github upload it, please use "save as..." and rename it to "JSMinNPP.dll")

from jstoolnpp.

NN--- avatar NN--- commented on May 28, 2024

Works

from jstoolnpp.

sunjw avatar sunjw commented on May 28, 2024

Thanks very much.

from jstoolnpp.

sunjw avatar sunjw commented on May 28, 2024

Fixed in and after version 1.20.2.
Download from:
http://www.sunjw.us/jstoolnpp/download.php

from jstoolnpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.