Code Monkey home page Code Monkey logo

Comments (7)

sherakama avatar sherakama commented on May 31, 2024

hmm. interesting.

Perhaps when we add our includes paths we only add 'node_modules' and not the full path to decanter. So to get everything your import would be:

@import 'decanter/decanter';

and to get at portions it would be

@import 'decanter/core/utilities/utilities';

from decanter.

sherakama avatar sherakama commented on May 31, 2024

This would be versus what we have when our include paths are set to 'node_modules/decanter'

eg:

@import 'decanter';
@import 'core/utilities/utilities';

from decanter.

kgcreative avatar kgcreative commented on May 31, 2024

I thought about that, but that has other implications. This allows us to namespace rollups, without having to remove underscores. So any '_decanter-*' file we know is a rollup, and doesn't contain actual funtionality, plus, when importing, this makes it clearer when you are calling a decanter-specific rollup versus your own.

I'm ok with actual mixins, base files, functions, etc not being namespaced, but namespacing the rollup files gives us much more flexibility when developing.

so,
@import 'utilities/decanter-utilities'; vs @import 'decanter/utilities/utilities vs @import utilities/utilities;

from decanter.

kgcreative avatar kgcreative commented on May 31, 2024

(there's something that feels dangerous about adding npm path to our scss import paths, vs adding individual components, but I haven't quite figured out what.)

from decanter.

sherakama avatar sherakama commented on May 31, 2024

From what I have seen a number of projects are using this: http://eyeglass.rocks/

I haven't fully grokked it yet but this seems to be a standard or convention for managing node modules in sass.

from decanter.

kgcreative avatar kgcreative commented on May 31, 2024

I believe both bourbon and neat can be eyeglass modules. I haven't quite grokked it yet, so i've been kicking that can down the road, since I don't want to add too much weight to our libraries

from decanter.

kgcreative avatar kgcreative commented on May 31, 2024

(this can be closed)

from decanter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.