Code Monkey home page Code Monkey logo

Comments (10)

koba04 avatar koba04 commented on June 13, 2024 15

What's the current status of this project?

styled-components recommends using this for stylelint, so many developers would think that using this processor with stylelint is an official way to use stylelint with styled-components.
https://styled-components.com/docs/tooling#stylelint

But this still uses the old version of Babel, so we cannot use new ES syntaxes and TypeScript syntaxes with this processor.
#296

This is a pitfall to combined styled-components and stylelint, so I think deprecating this package is an important message for developers.

I think styled-components updates the document, but it's an another issue.
styled-components/styled-components-website#671

from stylelint-processor-styled-components.

chinesedfan avatar chinesedfan commented on June 13, 2024 7

I was out of the world of stylelint too long. According to stylelint's CHANGLOG,

  • v9.4, introduced syntax: styled to support css-in-js, which was based on postcss-styled
  • v9.10, replaced postcss-styled with the more powerful postcss-jsx and changed the option as syntax: css-in-js
  • v10.0, removed the deprecated syntax: styled completely

After read some codes of postcss-jsx, I think it is the better way to lint styled-components files, even thought it still has lots of differences with this processor. Because it analyzes the whole AST more completely and can give more accurate replacements for tagged template interpolations. In later days, I will open issues for postcss-jsx to make this processor's abilities be 100% migrated smoothly.

from stylelint-processor-styled-components.

chinesedfan avatar chinesedfan commented on June 13, 2024 4

@evilebottnawi Looks good. Thanks for your information. I will play it more before giving a final decision. (cc @emilgoldsmith @mxstbr)

from stylelint-processor-styled-components.

chinesedfan avatar chinesedfan commented on June 13, 2024

@evilebottnawi Can you provide more details about it? Is it due to some new features introduced by the latest stylelint?

from stylelint-processor-styled-components.

alexander-akait avatar alexander-akait commented on June 13, 2024

@chinesedfan it is built-in feature since 10 version https://github.com/stylelint/stylelint#features

from stylelint-processor-styled-components.

emilgoldsmith avatar emilgoldsmith commented on June 13, 2024

Awesome to hear :)

from stylelint-processor-styled-components.

mxstbr avatar mxstbr commented on June 13, 2024

I think that's a great idea

from stylelint-processor-styled-components.

alexander-akait avatar alexander-akait commented on June 13, 2024

@chinesedfan friendly ping, what is status?

from stylelint-processor-styled-components.

chinesedfan avatar chinesedfan commented on June 13, 2024

@evilebottnawi I have opened gucong3000/postcss-jsx#62. But not sure when @gucong3000 or somebody else has time to solve them.

from stylelint-processor-styled-components.

alexander-akait avatar alexander-akait commented on June 13, 2024

Thanks!

from stylelint-processor-styled-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.