Port to Anki 2.1.0 about crowdanki HOT 7 CLOSED

I have written a port for Anki 2.1.0. friebetill/CrowdAnki
There were not many changes necessary and at first glance everything works quite well.

I don't know if a pull request is appropriate, because the port is not compatible with Anki 2.0.

from crowdanki.

yep, you're right :)

from crowdanki.

Hi, thank you for the feedback.
It's not API incompatibility, but python version incompatibility.
As 2.0 is stable version now, I prefer for plugin to be compatible with it.
But it should be possible to make it cross-version compatible :) I'll look into it.

from crowdanki.

I haven't looked into it for a while, but I think it's totally possible to make changes compatible.
I've briefly looked into the changes you've made and have a few comments:

• Running 2to3 conversion on the whole codebase is excessive. I wrote that code as Python3 initially and I think the only things that need to be fixed are a few imports and some unicode specific things
• It's especially true for thirdparty things - a lot of them are there because they are backports from python3 i.e. pathlib is natively present in P3 and most of the thirdparty things are consequence of using pathlib. I think the only thing beside it is uuid lib. So the only thing you need here to make things compatible is some try/except and aliasing on imports
• You removed support for AnkiHub registration for some reason
• The import fixes seems to be excessive too, the code was meant to be P2/P3 compatible and the new synthax is P3 only.

from crowdanki.

Thanks for looking into it though! I'd be happy to accept PR that maintains compatibility. Please see my comments above and feel free to create PR to discuss things in more details codewise.

from crowdanki.

Thanks for working on this, guys. Will be very useful when it's out. Good luck!

from crowdanki.

Is this closable now?

from crowdanki.