Code Monkey home page Code Monkey logo

Comments (7)

bakerboy448 avatar bakerboy448 commented on September 25, 2024

@bobokun do we compare save paths instead?

or can we compare file contents

from qbit_manage.

Quafley avatar Quafley commented on September 25, 2024

Hello,

@bobokun When will this issue be addressed? Files of mine have been getting deleted consistently. I can't configure anything differently, so I am simply accepting the loss at the moment. Would be nice if there would be an ETA as I deem this a pretty serious issue myself.

from qbit_manage.

Quafley avatar Quafley commented on September 25, 2024

I personally believe the error to be in this function:

https://github.com/StuffAnThings/qbit_manage/blob/db5e881581ae4a8677961adf0b1dc043df15f114/modules/qbittorrent.py#L96C10-L96C10

Where this might ultimately cause the issue:

self.torrentinfo[torrent_name] = torrentattr

I do not, however, have a fix.

from qbit_manage.

bobokun avatar bobokun commented on September 25, 2024

Hi can you please test the latest develop version and let me know if you still have this problem? Thanks!

from qbit_manage.

datcactus avatar datcactus commented on September 25, 2024

Reached out via Discord but while this solves the issue with the originally reported torrent it does not resolve the issue with other torrents that have significantly different naming conventions for the torrent/release name despite still having the same underlying files.

Examples from a couple of trackers:
BLU/BHD: 'Ninja.Kamui.S01E01.1080p.HMAX.WEB-DL.DD2.0.H.264-VARYG.mkv' is both the release name and filename
Nyaa: 'Ninja Kamui S01E01 1080p HMAX WEB-DL DD2.0 H 264-VARYG (Dual-Audio, Multi-Subs)' is the release name via magnet

The remove_extension function that was added will help in situations where the only difference in release names is an extension, but a better solution to this problem would be to create a mapping of torrent names/hashes to the files associated with them and use that as a comparison point when running the deletion logic. qbittorrent-api provides https://qbittorrent-api.readthedocs.io/en/latest/apidoc/torrents.html#qbittorrentapi.torrents.TorrentsAPIMixIn.torrents_files that can be used as a way to gather the files, and a list of dictionaries (or a nested dictionary) could be used to store the data to later iterate over.

from qbit_manage.

bobokun avatar bobokun commented on September 25, 2024

I've reverted the change for now to remove the extension until a proper fix

from qbit_manage.

bobokun avatar bobokun commented on September 25, 2024

@datcactus , can you please test again. The new logic uses save_files to determine cross-seeds so it should be more accurate than using names

from qbit_manage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.