Code Monkey home page Code Monkey logo

Comments (1)

titouanmathis avatar titouanmathis commented on July 20, 2024

This is a side effect of a design decision. When defining children components in config.components, the keys can either be the name of a component or a CSS selector. Components are then looked up in the following order:

  1. It tries to find any [data-component="${name}"] HTML element
  2. If no element was found, it falls back to using name as a CSS selector by doing querySelectorAll(name)

You can find the code for this here: https://github.com/studiometa/js-toolkit/blob/develop/packages/js-toolkit/Base/utils.ts#L59-L77

The querySelector('Figure') method will also match against <figure> elements, ignoring the case of the selector. We could add a check to avoid the fallback if the selector is not in lowercase.

from js-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.