Code Monkey home page Code Monkey logo

Comments (14)

stubailo avatar stubailo commented on June 10, 2024

Thanks, a repro would be much appreciated!

from meteor-reactive-method.

ecwyne avatar ecwyne commented on June 10, 2024

@stubailo Here's the repro

from meteor-reactive-method.

ecwyne avatar ecwyne commented on June 10, 2024

Especially notice that you can only click invalidate button once.

from meteor-reactive-method.

ecwyne avatar ecwyne commented on June 10, 2024

Is a Computation automatically "stopped" onInvalidate?

https://github.com/meteor/meteor/blob/devel/packages/tracker/tracker.js#L567

And then ReactiveMethod deletes computation here?

from meteor-reactive-method.

stubailo avatar stubailo commented on June 10, 2024

I don't think you posted the repro when you said "Here's the repro"

from meteor-reactive-method.

ecwyne avatar ecwyne commented on June 10, 2024

Look at the original comment. My bad

from meteor-reactive-method.

ecwyne avatar ecwyne commented on June 10, 2024

I believe I got it working. Check out how I did so manually in the working branch of my repo

https://github.com/ecwyne/reactive-method-issue-10/blob/working/invalidate-example.js#L16-L17

from meteor-reactive-method.

ecwyne avatar ecwyne commented on June 10, 2024

After deleting the _reactiveMethodData property we need to run the Computation._compute() method instead of the Computation.invalidate() method

from meteor-reactive-method.

ecwyne avatar ecwyne commented on June 10, 2024

PR: #11

from meteor-reactive-method.

Dsyko avatar Dsyko commented on June 10, 2024

I ran into this issue as well, hoping PR #11 fixes this :)

from meteor-reactive-method.

patrickdevivo avatar patrickdevivo commented on June 10, 2024

I'm having this issue as well, has it been resolved by PR #11?

from meteor-reactive-method.

bshamblen avatar bshamblen commented on June 10, 2024

+1

from meteor-reactive-method.

andfs avatar andfs commented on June 10, 2024

I think that the error is because the command:
recordMethodComputation(cc, serializedArgs);

is inside the else and this command should run for both conditions (if and else)

from meteor-reactive-method.

saliksaly avatar saliksaly commented on June 10, 2024

+1

from meteor-reactive-method.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.