Code Monkey home page Code Monkey logo

Comments (6)

simondel avatar simondel commented on July 16, 2024

I think we'll need to change our API to allow you to choose where you want to save your report. Perhaps we could add a property to the StrykerOptions of type any or something similar so it's generic. We'll also have to specify our SonarQube connection somewhere. grunt-sonar-runner does this in your Gruntfile. I'm not a big fan of saving credentials in a config because you may accidentally commit it. What do you think?

from stryker-js.

nicojs avatar nicojs commented on July 16, 2024

The StrykerOptions already has custom config of type any. We could do the same thing as stryker-html-reporter does and read options like this:

if (this.options['sonarReporter'] && this.options['sonarReporter']['username']) {
}

If we cannot think of sane defaults, we should throw an error early (before mutation testing).

We'll also have to specify our SonarQube connection somewhere. grunt-sonar-runner does this in your Gruntfile

You mean that the Sonar Qube plugin java (or scala?) application needs to do that? If i read my original issue from April 1st, that would be the case correct? Is it still up-to-date? Either way i'm not a fan of this either. We should use environment variables for it, with maybe a fallback to configuration.

from stryker-js.

philippw avatar philippw commented on July 16, 2024

Can we close this issue, now that we have the stryker-mutator/sonar-stryker-plugin?

from stryker-js.

wannesvr avatar wannesvr commented on July 16, 2024

Not sure if this is a mistake or not, but in the readme.md at step 4 it states that you have to 'move the jar to the downloads folder of your sonar qube instance (for example: /sonarqube-6.2/extensions/downloads)'.

Shouldn't downloads be plugins (I remember it to be plugins)?

from stryker-js.

nicojs avatar nicojs commented on July 16, 2024

I think sonar takes it from the downloads folder and puts it in the plugins folder

from stryker-js.

nicojs avatar nicojs commented on July 16, 2024

@philippw Yes, we can! 👍

from stryker-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.