Only works in English locale. about filter-other-days HOT 5 CLOSED

Hey, so sorry I completely forgot about this ticket!

This is definitely something I'd be interested in fixing. I may get around to it eventually but if anyone wants to work on this, I would love to merge a Pull Request that does the following:

1. Builds month names from whatever locales are present on the user's system
2. Implements a test suite for this. Probably you'll want to have a "basic" test suite that uses the English locales and runs by default and a "full" test suite that requires several locales and runs in CI

I am honestly not sure how to get this information out of the system locale. Now that I think about it I guess we could ship some static files with locale information? But that seems unideal. I'd really prefer to use the system locales.

Also note that the short-form of month days does are necessarily the first three letters of the long name.

Is there a good way to determine whether this will be the case? Can you get this information out of the system locales? If not, I guess we should just hardcode behavior for different locales...?

from filter-other-days.

Just as an FYI, there's work-in-progress code for this in #25.

from filter-other-days.

The code for this is still something I'd like to finish up and land.

from filter-other-days.

For those following along at home, I just provided an update on this in #25 (comment). tl;dr this is now blocked on a FreeBSD bug. We will probably work around the bug but I'm waiting to hear back from the FreeBSD folks.

from filter-other-days.

FYI, this has been out for a bit in filter-other-days 2.0.0! See https://strugee.net/blog/2019/12/filter-other-days-1.1.0-and-2.0.0-are-now-available

from filter-other-days.