Comments (3)
So i fiddled around with if for a bit and find that it doesn't reproduce if i don't create a new assert and just pass t everytime i call it:
So there's a workaround at least.
I looked around the t.Run and assert implementations and got confused but i think it's related to assert.t not being the same as t that is used in t.Run
so when Fail() calls t.Errorf(), which calls it's own Fail() it's modifying different t's?
But if that was the case then it wouldn't only not set c.failed, i would also not set c.parent with Fail()
As i said, i'm confused, this is confusing, imma go study interfaces now and hope that sheds some light into the matter, at least to me.
from testify.
You're basically on the right track. The top level testing.T
that you pass in to assert.New
and the testing.T created when invoking t.Run
are different. In your first example, no assertions are made against your subtest so its reports passing. You would basically have to do something like this.
func TestNotNil(t *testing.T) {
a := assert.New(t)
t.Run("Test Not Nil Sub", func(t *testing.T) {
passed := a.NotNil(t)
if !passed {
t.Fail()
}
})
}
but as you discovered, you can skip using assert.New
all together.
from testify.
I get it, since i'm declaring a outside t.Run(), even if i use it inside, it will reply to the whole test so i have to manually fail t.Run().
a isn't failing the parent, it still IS the parent and fails itself.
Thank you, this insight was really helpful
from testify.
Related Issues (20)
- How can I get coverage in the Suite package HOT 6
- Fix CVE-2022-28948 - Remove `gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c` HOT 3
- assert: Equal does not consider Zone information in time.Time
- Update Github actions workflows from nodejs 16 to nodejs 20 before "Spring 2024" HOT 1
- mock: Call.NotBefore still expects calls removed with Call.Unset HOT 6
- unnecessary/incorrect log call in AssertExpectations HOT 2
- Data race when mock is called with refernce to same object as expectation HOT 1
- assert fails and expects to dereference a reference HOT 1
- Add GoLang 1.22 to CI Testing Matrix for Package Compatibility Verification HOT 2
- error while importing github.com/stretchr/testify/suite: read C:\Program Files\Go\src\math\huge_test.go: unexpected NUL in input HOT 1
- AnythingOfType is marked deprecated on pkgsite HOT 1
- .On().Return() doesn't enforce expectation for the returned value HOT 1
- v1.9.0 breaks float comparisons with EqualValues HOT 6
- mock: cleanup argument matching API HOT 7
- Integer overflow in time.Time comparison
- EqualExportedValues can compare two slices HOT 2
- Regexp accepts interface{} HOT 3
- Drop outdated/abandoned dependencies HOT 3
- Proposal: Must-like utility HOT 3
- Proposal: assert.NotElementsMatch() HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testify.