Code Monkey home page Code Monkey logo

Comments (2)

dolmen avatar dolmen commented on May 29, 2024 1

@RemiMattheyDoret This proposal looks good. However the existing type switch must be preserved (for speed) and the switch on reflect.Kind must be added in the existing default case (like mentioned in the "Consideration" section).

Also: because this change will allow us to accept typed numbers in InDelta* and InEpsilon*, I think that we must enforce that if the type of the expected value has a non-anonymous type, the actual value must be exactly of that type. So changes in InDelta and InExpsilon are expected too:

if reflect.TypeOf(expected).PkgPath() != "" {
    IsType(t, expected, actual)
}

Both changes must happen at the same time: if we introduce the toFloat change first, the type check applied later would be then a breaking change.

As this change extends the behavior it will have to happen on a minor (not patch) release.

from testify.

dolmen avatar dolmen commented on May 29, 2024

Test case: https://go.dev/play/p/lGe4Y-2aBfz

func Test(t *testing.T) {
	type F64 float64

	assert.InDelta(t, F64(1.0), F64(1.0), 0.1) // This should succeed
	assert.InDelta(t, 1.0, F64(1.0), 0.1)      // This should succeed
	assert.InDelta(t, F64(1.0), F64(1.0), 0.1) // This should fail: not the expected type

	assert.InEpsilon(t, F64(1.0), F64(1.0), 0.1) // This should succeed
	assert.InEpsilon(t, 1.0, F64(1.0), 0.1)      // This should succeed
	assert.InEpsilon(t, F64(1.0), F64(1.0), 0.1) // This should fail: not the expected type
}

So far all tests fail with "Parameters must be numerical".

from testify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.