cpu widget gets placed off screen sometimes about awesome-wm-widgets HOT 1 OPEN

Hello @saevarb,

I did some poking around to understand what's going on here.

[...] but only in the beginning. Hiding it and then clicking again correctly respects screen boundaries.

Basically, when you click on the widget, a timer is started to regularly "query" all the data and draw/update the widget displayed in the popup. The very first time the popup is visible, the timer has never run before, hence the widget is empty and Awesome tries to place a { width = 1, heigth = 1 } popup.

As a little experiment, if I change the following code

with a delayed call for the popup:move_next_to (0,5 so that the timer callback has enough time to complete the work once)

                            -- popup:move_next_to(mouse.current_widget_geometry)
                            gears.timer {
                                timeout = 0.5,
                                single_shot = true,
                                autostart = true,
                                callback = function()
                                    popup:move_next_to(mouse.current_widget_geometry)
                                end,
                            }
                            -- Restart the timer, when the popup becomes visible
                            -- Emit the signal to start the timer directly and not wait the timeout first
                            popup_timer:start()
                            popup_timer:emit_signal("timeout")

The popup is correctly place from the first call!

This is NOT the solution you are looking for, but at least it points out the real issue. This timer logic was introduced with PR #246, so CC @atopion :)

I think the path forward is to separate the UI logic from the business logic. AKA the popup_timer:connect_signal('timeout' callback shouldn't be building the widget, but only updating the values. With this kind of separation, it's easier to have a "first draw" with default values to initialize the popup content.

from awesome-wm-widgets.