Code Monkey home page Code Monkey logo

Comments (11)

matkoniecz avatar matkoniecz commented on September 26, 2024 2

In such case it is much better to open a new issue requesting removal (unless it was opened and closed already?)

Comments in old issues are likely to be missed

from streetcomplete.

Arthur-GYT avatar Arthur-GYT commented on September 26, 2024 1

I'll will take a look as soon as I can.

from streetcomplete.

westnordost avatar westnordost commented on September 26, 2024

@Arthur-GYT

from streetcomplete.

westnordost avatar westnordost commented on September 26, 2024

Regarding spamminess: Indeed, more than 99% of parcel lockers tagged with parcel_pickup do have parcel_pickup=yes, so indeed it seems to be a good idea to at least disable that quest by default.

Regarding brands: Hmm, really not sure if this would really always the same for the same brand. A situation where a brand have different types of lockers, some allowing e.g. mail-in and others not would be completely possible. Also, note that that quest just asks for the brand, and then just tags the brand, nothing else. It does not use any NSI presets.

from streetcomplete.

rhhsm avatar rhhsm commented on September 26, 2024

Did some more research in the meantime: only 0.42% (130) of parcel lockers have parcel_pickup=no. They are fairly evenly spread over the world, i.e. there is no particular country where most of them are located. None of them are in Bulgaria. In the Netherlands, there were two: one DHL which according to DHL website does allow parcel pickup, and one PostNL where the website doesn't mention pickup at all, possibly because it's obvious. Both the DHL and PostNL parcel locker presets in iD contain parcel_mail_in=yes and parcel_pickup=yes tags. I suspect that a large number of parcel lockers with parcel_pickup=no are wrongly tagged.
parcel_mail_in values are more spread: almost 90% yes, 8.6% no and about 2% return only, so seems more suitable for a quest.

from streetcomplete.

matkoniecz avatar matkoniecz commented on September 26, 2024

one DHL which according to DHL website does allow parcel pickup

Have you fixed it or opened note for that?

from streetcomplete.

westnordost avatar westnordost commented on September 26, 2024

Note that parcel_mail_in=returns_only occurs very rarely, so it can be fine to just leave a note in this case.

from streetcomplete.

westnordost avatar westnordost commented on September 26, 2024

I've looked it over right now, and I prefer leaving the pickup quest active by default. It is true that the answer is pretty much always the same, but the user is already in front of the locker and just read the information on it, so he can immediately answer it.

from streetcomplete.

westnordost avatar westnordost commented on September 26, 2024

I went ahead and fixed it.

from streetcomplete.

rhhsm avatar rhhsm commented on September 26, 2024

The more I think about this, the more I'm convinced that these quests should not be on SC at all, because they don't meet the quest guidelines and there are much better ways to add the information than a survey.

The parcel locker pickup quest is way too spammy, as the answer is almost always yes. Parcel lockers are there to pick up parcels, it's their main function. 99.53% of the parcel_pickup tag has value yes (isn't that "an overwhelming percentage"?), and I suspect that the almost 40% of parcel lockers that don't have this tag are also yes because it's the default value.

The parcel locker mail in quest probably also has an overwhelming percentage of quests with the same answer, if you look at each brand separately. The websites of parcel locker brands I've seen all describe their mail in possibilities in general terms, which suggest that for each brand, they either always allow (yes, 90% according to taginfo), not allow at all (no, 8.6%) or returns_only (2%). This information is then much easier to retrieve from the brand's website and added to the brand preset instead of asking SC users to survey each parcel locker to check it. I don't think we should waste SC users' time on this. The quest should only be active for parcel locker brands where the value varies between lockers, which I suspect are very few.

from streetcomplete.

mnalis avatar mnalis commented on September 26, 2024

I'd just add that usually it is better solution to request disabling quest by default if needed, instead of removing it.

(people who use those quests, for whatever reason, are likely to object to removal of already existing quests, especially if in their own small corner of the map the quest is more useful then globally)

from streetcomplete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.