Code Monkey home page Code Monkey logo

Comments (8)

sparkpunkd avatar sparkpunkd commented on September 23, 2024 1

We are still finding our way with license choice having previously worked on projects under Apache 2.0 licensing. We'll have a discussion and review the choice. Somehow we need to kick the license can down the road so that the beamcoder license varies with the version. You can call:

beamcoder.licenses()

to see the list of licenses that beamcoder is runtime linking with.

FYI, the reason for choosing GPL-3 when writing beamcoder was that the released v4.1 libraries we download as part of the install process on Windows are compiled with --enable-gpl --enable-version3. We also wanted to include libx264 and libx265 as we have real use cases for these, so the linux builds we are working with have --enable-gpl.

from beamcoder.

jeremy-j-ackso avatar jeremy-j-ackso commented on September 23, 2024

I get where you're coming from. All the different licenses that come with codecs gets complex really quickly. The main reason I made the suggestion is for users who may want to link against non-free codecs, which is (as I understand it) the reason for licensing under LGPL.

Maybe one way to go about it would be to do something like eslint does, where the developer walks through a wizard, choosing options that are added to a config file. Then, when npm install beamcoder is run it looks for the config file and compiles itself and FFMpeg according to those options if the config file is present. If the config file is not present, then the npm install will output a message asking the user to run node_modules/beamcoder/bin/beamcoder.js --init or something like that, which will launch the wizard, create the config file, attach applicable licenses, and run the compile.

from beamcoder.

jeremy-j-ackso avatar jeremy-j-ackso commented on September 23, 2024

Thinking about it, such an FFmpeg compiler could even be its own module that beamcoder calls in to as part of its installation.

Hmmmmm. Might do some experimentation this week.

from beamcoder.

jeremy-j-ackso avatar jeremy-j-ackso commented on September 23, 2024

Or, for that matter, ffmpeg-static could be added as a dependency rather than having the preinstall script?

from beamcoder.

sparkpunkd avatar sparkpunkd commented on September 23, 2024

Beam Coder needs to link against shared libraries. ffmpeg-static is primarily for when you execute ffmpeg as an external process.

from beamcoder.

jeremy-j-ackso avatar jeremy-j-ackso commented on September 23, 2024

Beam Coder needs to link against shared libraries.

Sure, but that's a requirement that's being opted in to.

Beamcoder's install_ffmpeg.js downloads FFMpeg from the same locations as ffmpeg-static does for the Windows and Linux cases, it just inflates them to a project-local directory rather than the system shared location.

from beamcoder.

jeremy-j-ackso avatar jeremy-j-ackso commented on September 23, 2024

I guess I'll take that back. I missed that ffmpeg-static grabs slightly different things.

My bad.

from beamcoder.

rezonant avatar rezonant commented on September 23, 2024

Please consider switching this to LGPL to match ffmpeg. As of now I'll have to build an entirely new set of bindings which is a shame :-(

from beamcoder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.