Code Monkey home page Code Monkey logo

Comments (6)

MisterTimn avatar MisterTimn commented on August 25, 2024 1

First thing I'm noticing is how the config of these storageclass has been spread throughout the different components and everytime it has been tackled in a different way.

In prometheus its handled inside the pvc-template
In zookeeper and bookkeeper its handled in the helpers but each in its own way (print functions vs full include defines.

I'm working on just adding the storageClassName now but maybe we should move towards a unified and more concise way of handling this? Define these classes in the same way across all components.

I have always enjoyed bitnami charts and how they do the defining of storage classes
Reference:
https://github.com/bitnami/charts/blob/007da4ff5a6b80968525a324219645c668cd6fed/bitnami/influxdb/templates/_helpers.tpl#L270
https://github.com/bitnami/charts/blob/007da4ff5a6b80968525a324219645c668cd6fed/bitnami/influxdb/values.yaml#L529

If we would adapt such a style this would mean quite a big overhaul.

from charts.

MisterTimn avatar MisterTimn commented on August 25, 2024 1

Ive made a PR with just the addition of the storageClassName values for now, don't have any spare time at the moment to overhaul/streamline volume config throughout the chart.

from charts.

sijie avatar sijie commented on August 25, 2024

@MisterTimn Yes! That sounds like a good idea. Would you like to make a contribution?

from charts.

sijie avatar sijie commented on August 25, 2024

@MisterTimn Looks good to me! Let's move towards that direction.

from charts.

sijie avatar sijie commented on August 25, 2024

@MisterTimn Thank you!

from charts.

sijie avatar sijie commented on August 25, 2024

This is fixed by #127

from charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.