Comments (6)
First thing I'm noticing is how the config of these storageclass has been spread throughout the different components and everytime it has been tackled in a different way.
In prometheus its handled inside the pvc-template
In zookeeper and bookkeeper its handled in the helpers but each in its own way (print functions vs full include defines.
I'm working on just adding the storageClassName now but maybe we should move towards a unified and more concise way of handling this? Define these classes in the same way across all components.
I have always enjoyed bitnami charts and how they do the defining of storage classes
Reference:
https://github.com/bitnami/charts/blob/007da4ff5a6b80968525a324219645c668cd6fed/bitnami/influxdb/templates/_helpers.tpl#L270
https://github.com/bitnami/charts/blob/007da4ff5a6b80968525a324219645c668cd6fed/bitnami/influxdb/values.yaml#L529
If we would adapt such a style this would mean quite a big overhaul.
from charts.
Ive made a PR with just the addition of the storageClassName
values for now, don't have any spare time at the moment to overhaul/streamline volume config throughout the chart.
from charts.
@MisterTimn Yes! That sounds like a good idea. Would you like to make a contribution?
from charts.
@MisterTimn Looks good to me! Let's move towards that direction.
from charts.
@MisterTimn Thank you!
from charts.
This is fixed by #127
from charts.
Related Issues (20)
- [sn-platform] Remove the presto config `pulsar.managed-ledger-num-worker-threads`
- sn-platform-streamnative-console failed to initialize as /pulsar-manager/gateway/gateway-entrypoint.sh not found HOT 5
- Pulsar Operator: PulsarProxy is not able configure correct Liveness check for WebSocket HOT 3
- Toolset initContainer busybox crash
- Busybox cli not work in toolset
- Pulsarctl config can't be loaded
- Improve logic when jwt and vault enabled both
- [pulsar-operator]Fix rbac issue when watching specific namespace
- upgrade pulsar image to 3.0
- Wrong namespace for RBAC and clusterrole with multi-namespace
- [sn-platform][fix]: toolset.kafka container doesn't support non-root user
- [charts/sn-platform] pulsar detector only support "token" auth in template. HOT 1
- [pulsar-operator] how to set different kafkaAdvertisedListeners for different pulsar broker pod
- [sn-platform] Support migrate from non-Istio to Istio
- fix: detector missed the resources limit on the server container.
- feat: support some extra configures on the detector
- [sn-platform] Avoid downloading in Job jwt-secret-init
- Can't specify imagePullSecret for jwt init job
- Support setting the resources for the backup service
- [pulsar-operator] Disable/Debug startup probe failure
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from charts.