Comments (7)
First of all, thanks for the great feedback, really appreciate it :-)
User facing input always expects local timezones, as some people won't even know what UTC means. I will investigate it tonight and update this issue with my findings ok?
from core.
Ah pesky little bug, I found you: https://github.com/strautomator/core/blob/master/src/recipes/conditions.ts#L195
The timezone offset is being added for the activity starting time, but not the end time. Will be fixed and deployed on the weekend ok?
Once again, thanks for the report!
from core.
Hi @OleksiyRudenko can you please give me your Strava account ID? I made some tests with random timezones and could not find any issues. I'll have to check the logs specifically for your account and see what Strava is returning there.
from core.
Hi @igoramadas, thank you for looking into this.
My acc is https://www.strava.com/athletes/121765792
This activity ended before 9:30 my local time (according to the info available to me - 8:09 started + 41'30" elapsed time, moving time was 25'41"): https://www.strava.com/activities/10134503463
I had to adjust this recipe https://strautomator.com/automations/edit?id=r6540cbb4 conditions and re-run automation manually to have the expected effect (meaning actions are not applied).
{
"property": "dateEnd",
"value": 30600,
"operator": ">",
"friendlyValue": "08:30" // originally, this was set to 9:30
}
Hope the above helps.
Upd 11:12 UTC: Apologies for any confusion due to the inital content of this message.
Upd:
So, I expected the automation above to trigger between 9:30 and 18:30 my local time prepending the activity name with a specified prefix.
One of the activities ended before 9:30, yet the recipe has been triggered and actions taken.
I changed the endTime
in the recipe, have manually re-run automations and the result was as expected (the activity name was reset with a different automation and automation in question didn't add anything, just as expected).
I tried to reproduce this now by changing endTime
to 9:30 and actions of this automation were not applied, as expected.
I changed back to 8:30 and they again were not applied (however, should have been if respected, as end time for this activity definitely falls into 8:30-17:30 range).
I am confused now myself and probably confused you. My apologies for this. I might have really missed something important or simply misusing the tool.
I will revert to you with a more consistent test and accurate steps to reproduce if any issues arise.
from core.
hi @igoramadas , I guess I caught it redhanded :)
This activity started at 18:33 and ended at 19:00 my local time (CET).
This automation triggering conditions are:
If ALL these conditions are met:
- Week day is Monday or Tuesday or Wednesday or Thursday or Friday
- End time is after 9:30 h
- End time is before 18:30 h
I wouldn't expect it being triggered, but it was. Please correct me if I am wrong.
from core.
Issue flagged as stale for being inactive for 28 days, please report status if this is still relevant.
from core.
Issue closed due to inactivity, feel free to update and re-open it if necessary.
from core.
Related Issues (20)
- Improvement OpenAI generated name: translation support HOT 4
- Weather tags translation improvements HOT 5
- Spotify integration not working HOT 7
- [Feature request] : mixing AND and OR HOT 3
- Bug: Automation keeps getting disabled HOT 8
- Feature request: Mark ride as NOT commute HOT 5
- Lithuanian language HOT 6
- Condition on app name HOT 3
- perceivedExertion not being expanded in template HOT 2
- ${maxPace} for indoor activities HOT 7
- Does AI consider temperature being specified in Fahrenheit? HOT 7
- Account settings not saved HOT 2
- action to trigger "adjust elevation" for activities HOT 4
- AI activity name cutoff HOT 4
- Feature Request: Enhanced Private Notes Functionality HOT 3
- Add option to remove "accidental" stop/starts from activity HOT 2
- Feature request: mid-ride location and weather tags HOT 4
- AI prompt makes me look bad 😅 HOT 4
- Add condition to check if there are any Spotify tracks HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.