Comments (11)
This has been fixed in this PR : #133
However, it's only available in the v4 branch of this plugin.
I'll try to backport it to a v3 branch
from addon-svelte-csf.
You could post on the Svelte Discord and tag me. I have the same username there
from addon-svelte-csf.
I'm going to try to get us upgraded to Svelte 4. That's where we should be an it's more efficient than trying to hack a backport. Will report back here if that fails. Appreciate your help here.
from addon-svelte-csf.
@JReinhold do you know if the current github action can do a release on the v3 branch ?
from addon-svelte-csf.
Much appreciated. I wish I could just upgrade to Svelte 4, but that's a bigger project than I'd hoped, so a back port would help me out a ton.
from addon-svelte-csf.
@eyeseast As a workaround, you can stick to v3.0.4, it's probably the latest working version with webpack in the v3 branch.
from addon-svelte-csf.
I kept hitting different errors when I tried to downgrade, so I settled for a temporary solution of using intermediate components with all the necessary markup, and then rendering those inside a <Template>
or <Story>
. Not ideal, but it'll work until I can get us upgraded to Svelte 4.
from addon-svelte-csf.
@eyeseast any particular part that's making a Svelte 4 upgrade a big upgrade for you? We meant to make Svelte 4 generally pretty easy to upgrade for most users, so I wanted to check if there's anything we need to add to the migration guide or anything like that
from addon-svelte-csf.
@benmccann I think it's a dependency issue. I was working quickly, trying to solve this and not really looking at the upgrade process, and ran into errors that were hard to trace. I'm going to try again as soon as I get through a different project, so I should have more feedback then.
Is there a good place to report upgrade issues, if I do come across them? Don't want to clutter up this thread with unrelated stuff.
from addon-svelte-csf.
Sorry I missed this @j3rem1e. Our tooling doesn't support backported releases, but we can definitely hack some branches together if we need it.
If it's impossible for @eyeseast to upgrade, then I'll look into releasing a new v3.
from addon-svelte-csf.
I`m closing this issue as fixed. Feel free to reopen it if needed.
from addon-svelte-csf.
Related Issues (20)
- Issue template should ask for version of Storybook and `addon-svelte-csf` that are being used HOT 3
- Unable to set slot description or default value HOT 1
- Migrate to new story indexer API HOT 3
- Svelte CSF Autodoc comments HOT 2
- [Bug] CSF Story Error HOT 2
- [Bug] Autodocs does not render Component name properly. HOT 8
- Posible to have typed args in the `<Template />` component? HOT 1
- [Bug] Support for `svelte 5` HOT 10
- [Bug] Setup with sveltekit fails HOT 6
- [Feature Request] Support for vite 5.x
- Request: typescript usage examples HOT 3
- [Request] A simple way to bind component story state to args HOT 2
- [Bug] Autodocs produce invalid code example HOT 2
- [Bug] cannot use some names in imports HOT 4
- [Bug] svelte-stories-loader doesn't preprocess stories when using Webpack
- [Bug] When calling the fn "superForm" from "sveltekit-superforms/client" we get error "Cannot destructure property 'story' of 'storyObject' as it is undefined." HOT 9
- [Bug] Custom Svelte event does not show up in actions tab? HOT 8
- Compatibility with Storybook 8 HOT 3
- [Bug] Not working with `getAbsolutePath('@storybook/addon-svelte-csf')` in Storybook 8 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from addon-svelte-csf.