[Bug] Stories with additional markup are breaking about addon-svelte-csf HOT 11 CLOSED

This has been fixed in this PR : #133
However, it's only available in the v4 branch of this plugin.

I'll try to backport it to a v3 branch

from addon-svelte-csf.

You could post on the Svelte Discord and tag me. I have the same username there

from addon-svelte-csf.

I'm going to try to get us upgraded to Svelte 4. That's where we should be an it's more efficient than trying to hack a backport. Will report back here if that fails. Appreciate your help here.

from addon-svelte-csf.

@JReinhold do you know if the current github action can do a release on the v3 branch ?

from addon-svelte-csf.

Much appreciated. I wish I could just upgrade to Svelte 4, but that's a bigger project than I'd hoped, so a back port would help me out a ton.

from addon-svelte-csf.

@eyeseast As a workaround, you can stick to v3.0.4, it's probably the latest working version with webpack in the v3 branch.

from addon-svelte-csf.

I kept hitting different errors when I tried to downgrade, so I settled for a temporary solution of using intermediate components with all the necessary markup, and then rendering those inside a <Template> or <Story>. Not ideal, but it'll work until I can get us upgraded to Svelte 4.

from addon-svelte-csf.

@eyeseast any particular part that's making a Svelte 4 upgrade a big upgrade for you? We meant to make Svelte 4 generally pretty easy to upgrade for most users, so I wanted to check if there's anything we need to add to the migration guide or anything like that

from addon-svelte-csf.

@benmccann I think it's a dependency issue. I was working quickly, trying to solve this and not really looking at the upgrade process, and ran into errors that were hard to trace. I'm going to try again as soon as I get through a different project, so I should have more feedback then.

Is there a good place to report upgrade issues, if I do come across them? Don't want to clutter up this thread with unrelated stuff.

from addon-svelte-csf.

Sorry I missed this @j3rem1e. Our tooling doesn't support backported releases, but we can definitely hack some branches together if we need it.

If it's impossible for @eyeseast to upgrade, then I'll look into releasing a new v3.

from addon-svelte-csf.

I`m closing this issue as fixed. Feel free to reopen it if needed.

from addon-svelte-csf.