Code Monkey home page Code Monkey logo

Comments (4)

ceddybi avatar ceddybi commented on June 18, 2024 1

@ellis no problem take your time, please accept the invitation I sent you to the team org so that you can contribute and add PRs

from ibkr.

ellis avatar ellis commented on June 18, 2024

Looking some more through your code, I'm wondering if the type of tickType could be changed to TickPrice | TickPrice[] in this interface:

interface SymbolWithTicker {
    tickerId: number;
    symbol: string;
    tickType?: TickPrice;
}

And then in prices.updates.ts instead of:

                // Matches as requested
                if (currentTickerType === tickTypeWords) {

Maybe something like:

                // Matches as requested
                if ((typeof currentTickerType === "string" && currentTickerType === tickTypeWords) || currenTickerType.includes(tickTypeWords)) {

Since I don't know your software architecture, I don't know whether that would actually fit though?

Also, I'm using delayed price data. Can you point me to where I should look for adding support for that to ibkr, if you're open to PRs?

from ibkr.

ceddybi avatar ceddybi commented on June 18, 2024

@ellis Thank you for pointing that out, you're welcome to push any PRs, let's start with this one checkout #57 please feel free to push and improve it 🙏

from ibkr.

ellis avatar ellis commented on June 18, 2024

@ceddybi Cool, will aim to test it in the next couple days.

from ibkr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.