Code Monkey home page Code Monkey logo

Comments (3)

LORDofDOOM avatar LORDofDOOM commented on July 2, 2024

Sound good. Also parallel processing is IMHO a important change because with sequential processing a buy is possibly to late.

Checking for new trades even if all traders are at work could possibly still be a useful option. If a trader sell it already have a buy option and could check if the TA is still valid

from mynt.

sthewissen avatar sthewissen commented on July 2, 2024

I could use input on a lot of things probably when it comes to this.

  1. First off I believe @cryptoandrej had the idea to combine the PaperTradeManager and the LiveTradeManager into one. Switching between the two would then be as simple as a boolean toggle in the constructor. I support that idea.

  2. The Initialize() method seems a bit redundant in many cases. Currently it runs before each buy loop and queries the database to see if it needs to create or change how the current trader instances are set up. This seems like a lot of overhead once the bot is up-and-running. Especially when trading lower timeframes a useless DB call every 1 or 5 mins seems like a total waste of resources. Could we simplify this Trader setup process?

I'm working on this in the trademanager-performance branch if anyone wants to pitch in :) If you have additional ideas on how to go about improving how the trademanager works at the moment, feel free to post here :)

from mynt.

twixwix avatar twixwix commented on July 2, 2024

Hey guys I think we have a thread issue with the initialize(); sometimes when the cron is to fast it hits that twice. So if DB context is already in use we have the problem from asynchronous DB context. We have some ways to get rid of that.

  1. Maybe a pseudo object which contains the DB context and we save it in the end so there would be no lock in database.

  2. Semaphore lock in sell or buy. Therefore only one task can go in the semaphore it is like a queue.

Parallel loops would be must have if we want more frequent trading bots.

But all in all I like the idea to get rid of duplicate code from traders...

from mynt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.