Comments (3)
Sound good. Also parallel processing is IMHO a important change because with sequential processing a buy is possibly to late.
Checking for new trades even if all traders are at work could possibly still be a useful option. If a trader sell it already have a buy option and could check if the TA is still valid
from mynt.
I could use input on a lot of things probably when it comes to this.
-
First off I believe @cryptoandrej had the idea to combine the
PaperTradeManager
and theLiveTradeManager
into one. Switching between the two would then be as simple as a boolean toggle in the constructor. I support that idea. -
The
Initialize()
method seems a bit redundant in many cases. Currently it runs before each buy loop and queries the database to see if it needs to create or change how the current trader instances are set up. This seems like a lot of overhead once the bot is up-and-running. Especially when trading lower timeframes a useless DB call every 1 or 5 mins seems like a total waste of resources. Could we simplify this Trader setup process?
I'm working on this in the trademanager-performance
branch if anyone wants to pitch in :) If you have additional ideas on how to go about improving how the trademanager works at the moment, feel free to post here :)
from mynt.
Hey guys I think we have a thread issue with the initialize(); sometimes when the cron is to fast it hits that twice. So if DB context is already in use we have the problem from asynchronous DB context. We have some ways to get rid of that.
-
Maybe a pseudo object which contains the DB context and we save it in the end so there would be no lock in database.
-
Semaphore lock in sell or buy. Therefore only one task can go in the semaphore it is like a queue.
Parallel loops would be must have if we want more frequent trading bots.
But all in all I like the idea to get rid of duplicate code from traders...
from mynt.
Related Issues (20)
- Back tester rework HOT 1
- CancelUnboughtOrders function HOT 3
- Binance transaction fee in BNB bug HOT 1
- Configuration problem HOT 4
- Provide a buying strategy HOT 8
- Add Huobi support HOT 1
- SQL Server not entirely working as planned HOT 5
- PaperTrade dont fill HOT 10
- local installation.. when? HOT 7
- Wiki Update - local installation HOT 3
- Installation (Azure) problem HOT 12
- ... HOT 6
- Mynt.AspNetCore.Host
- Problem with installation and configuration HOT 14
- Exception thrown when placing an order HOT 4
- how to run it as bot HOT 3
- hi , is this project continue updating? HOT 1
- Project from README.md is not accessible HOT 2
- About new project MachinaTrader HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mynt.