Comments (4)
Yes, you always want type fields to be a concrete type if possible.
from geometryprimitives.jl.
Sure, sounds good.
from geometryprimitives.jl.
Created a PR: #12.
from geometryprimitives.jl.
It turns out that we also need to change
mutable struct KDTree{K}
s::Vector{Shape{K}}
...
end
to
mutable struct KDTree{K,S<:Shape{K}}
s::Vector{S}
...
end
to fully resolve the issue discussed above.
In the outside module that deals with shapes that always carry auxiliary data of type D
, the shapes are always of type Shape{N,D}
instead of less specific Shape{N}
. Therefore, Shape{N,D}
is aliased to, e.g., Object{N}
for convenience, and a vector of these shapes is defined as Object{N}[obj₁, ..., objₙ]
. When such a vector is passed to the current KDTree
constructor to define the field s
, type conversion from Vector{Object{N}}
to Vector{Shape{N}}
does not occur because the former is not a subtype of the latter. The above described change will resolve this problem.
from geometryprimitives.jl.
Related Issues (10)
- Specifying radii in `Ellipsoid` (or diameter in `Sphere`) HOT 4
- Type instability of `surfpt_nearby` for abstract `Shape` HOT 5
- Infinite recursion in KDTree construction
- Updating to Julia 0.7/1.0? HOT 2
- TagBot trigger issue HOT 18
- Examples HOT 2
- Possible dispatch enhancements HOT 3
- Convention for`findfirst()` return value HOT 3
- `SurfaceLike` not defined error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geometryprimitives.jl.