Code Monkey home page Code Monkey logo

Comments (4)

stevengj avatar stevengj commented on July 19, 2024 1

Yes, you always want type fields to be a concrete type if possible.

from geometryprimitives.jl.

stevengj avatar stevengj commented on July 19, 2024

Sure, sounds good.

from geometryprimitives.jl.

wsshin avatar wsshin commented on July 19, 2024

Created a PR: #12.

from geometryprimitives.jl.

wsshin avatar wsshin commented on July 19, 2024

It turns out that we also need to change

mutable struct KDTree{K}
    s::Vector{Shape{K}}
    ...
end

to

mutable struct KDTree{K,S<:Shape{K}}
    s::Vector{S}
    ...
end

to fully resolve the issue discussed above.

In the outside module that deals with shapes that always carry auxiliary data of type D, the shapes are always of type Shape{N,D} instead of less specific Shape{N}. Therefore, Shape{N,D} is aliased to, e.g., Object{N} for convenience, and a vector of these shapes is defined as Object{N}[obj₁, ..., objₙ]. When such a vector is passed to the current KDTree constructor to define the field s, type conversion from Vector{Object{N}} to Vector{Shape{N}} does not occur because the former is not a subtype of the latter. The above described change will resolve this problem.

from geometryprimitives.jl.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.