Comments (3)
KeesCBakker
commented on June 30, 2024
@stephenyeargin, if you have some time, I might have something you can take a look at: KeesCBakker#2
from hubot-grafana.
stephenyeargin
commented on June 30, 2024
Looks like it takes care of the tagged issues, thank you! You should have write access now to this repository if you'd rather create branches there (so that the test suite runs against PRs).
from hubot-grafana.
KeesCBakker
commented on June 30, 2024
Yeah, upon testing I found some problems. Looks like the S3 route works, but the other routes can never work.
The grafanaDashboardRequest() on the Slack upload (https://github.com/stephenyeargin/hubot-grafana/blob/main/src/grafana.js#L611) can never work, as it will not return a URL but is a callback, as is defined here: https://github.com/stephenyeargin/hubot-grafana/blob/main/src/grafana.js#L726-L735
Trying to fix that as well, but Slack won't led me upload files.
Other broken cases:
- RocketChat, per: https://github.com/stephenyeargin/hubot-grafana/blob/main/src/grafana.js#L673
- Telegram, per https://github.com/stephenyeargin/hubot-grafana/blob/main/src/grafana.js#L700
The tests currently are not catching that those uploadTo things are broken. Do you manually test them?
from hubot-grafana.
Related Issues (20)
- Using with grafana server https self signed HOT 8
- Bar Guage not rendered correctly HOT 2
- When calling multiple graphs, only 2 show up HOT 7
- integrating with flowdock HOT 1
- ERROR SyntaxError: Unexpected token < in JSON at position 0 HOT 3
- graf db nginx-lua Why is the grafana homepage returned? HOT 8
- TimeZone support HOT 2
- Grafana 7: Full screen leads to localhost:3000 redirect HOT 4
- ERROR SyntaxError: Unexpected token < in JSON at position 0 HOT 3
- hubot-grafana does not work for Grafana 8 HOT 7
- Upgrade from 2.5.2 to 3.0.1: dashboards can't be accessed by slug anymore HOT 5
- Can only receive 1 image by each query which queries all panels in the dashboard HOT 2
- Allow the bot to respond in a thread HOT 2
- S3 Region breaks existing setup HOT 2
- Support for @hubot-friends/hubot-slack
- feat: clean the NPM package to make its footprint smaller
- Getting rid of the obsolete request dependency
- Tests are too slow or timing out HOT 2
- Download method needs API key in header HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hubot-grafana.