Code Monkey home page Code Monkey logo

Comments (6)

stephencelis avatar stephencelis commented on July 30, 2024

It detects HEAD if it's pushed and tracking.

$ git co -b topic-branch
$ ghi -v e 1 -H
fatal: HEAD can't be null
$ git push -u origin topic-branch
[...]
 * [new branch]      topic-branch -> topic-branch
Branch topic-branch set up to track remote branch topic-branch from origin.
$ ghi -v e 1 -H
===> POST /repos/user/repo/pulls {"head":"topic-branch","issue":"1","base":"master"}
[...]
$ ghi -v e 1 -Huser:
===> POST /repos/user/repo/pulls {"head":"user:topic-branch","issue":"1","base":"master"}

from ghi.

stephencelis avatar stephencelis commented on July 30, 2024

Thoughts on improving the situation:

  1. Making the fatal error message more helpful? Something like "fatal: HEAD can't be null (Is your current branch being tracked upstream?)", perhaps.
  2. Defaulting head user to the authorized user.

What do you think?

from ghi.

nijikokun avatar nijikokun commented on July 30, 2024

I think the first one would be better, having a more verbose error message; why not make -H -h ?

from ghi.

stephencelis avatar stephencelis commented on July 30, 2024

Because -h is typically help (in ghi and git). hub's command is an outlier.

from ghi.

nijikokun avatar nijikokun commented on July 30, 2024

a way around that would be to have a help command, but I digress;

from ghi.

stephencelis avatar stephencelis commented on July 30, 2024

Did you try it? It works just fine with -h if you provide an issue number.

from ghi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.