Code Monkey home page Code Monkey logo

Comments (10)

paperdave avatar paperdave commented on June 1, 2024 1

ah. got would be the next blocker after this, not just the simple parsing bug.

i think it is reasonable to add in your docs that bun support is blocked by these issues (can open a new issue in bun specifically for stepci to link, and that issue should point to got+the parsing bug). it is our responsibility to fix these all.

from stepci.

mishushakov avatar mishushakov commented on June 1, 2024 1

Will do! Really value your effort in helping Step CI run in Bun. Thanks for coming by 😃

from stepci.

mishushakov avatar mishushakov commented on June 1, 2024 1

Yes!

from stepci.

mishushakov avatar mishushakov commented on June 1, 2024

Hey, thanks for starting the issue!

It's a known issue with Bun, not related to Step CI.

from stepci.

sbhehe233 avatar sbhehe233 commented on June 1, 2024

Hey, thanks for starting the issue!

It's a known issue with Bun, not related to Step CI.

fair enough but shouldnt this be noted in the sample? ppl would think it’s supported while actually it isnt yet …

from stepci.

mishushakov avatar mishushakov commented on June 1, 2024

Yes, I think we should mention it in the docs. Can you contribute a fix to the doc?

from stepci.

paperdave avatar paperdave commented on June 1, 2024

It's a known issue with Bun

was there an open bug in bun before this one? sorry if it was missed. this seems to be a very trivial parser bug:

(a?.b)[1] = 2;

minimized from this line

(stepResult.checks?.messages)[check.id] = {

the optional chain is not handled by bun. i think we can fix this easily but i'm currently wrapped up in a lot of windows compat work.

from stepci.

mishushakov avatar mishushakov commented on June 1, 2024

Sorry, I meant that this is known issue among Step CI users using Bun, not Bun's issue in particular.
I'm not sure how the fix would look like.

Also, keep in mind that got, the library used by Step CI also does not work with Bun: oven-sh/bun#3150

from stepci.

sbhehe233 avatar sbhehe233 commented on June 1, 2024

Yes, I think we should mention it in the docs. Can you contribute a fix to the doc?

Sure here would probably be best?

from stepci.

sbhehe233 avatar sbhehe233 commented on June 1, 2024

Now this has been taken care of with bun 1.0.27 but a new issue has occurred unfortunately… will follow up with another thread cheers

from stepci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.