Comments (3)
howardtw
commented on July 17, 2024
@jedmccaleb looks like build.Asset is used by all the services other than horizon and it also looks like it's being replaced by txnbuild.Asset. Did you want to take Asset out from protocols/horizon/base and put it in the top level of protocols and have every single service use it? cc @ire-and-curses
from go.
ire-and-curses
commented on July 17, 2024
In txnbuild, I ended up implementing an Asset interface, and then simple structs for NativeAsset and CreditAsset. I'm not sure how much value I see in combining the types here.
from go.
howardtw
commented on July 17, 2024
@ire-and-curses is this still relevant? It was assigned to me a long time ago.
from go.
Related Issues (20)
- historyarchive: Harden the `ArchivePool` to be robust against errors.
- Refactor trade aggregations
- services/horizon: add config setting for toggle soroban tx-meta presence HOT 1
- services/horizon: Add the ability to toggle ingestion of Soroban elements HOT 1
- stellar-archivist does not hash the txset correctly for v20 ledgers.
- horizon/ingest: automatic best effort removal of captive core cursors during init HOT 2
- services/horizon/ingest: new metric label for bytes-downloaded on history archive metrics HOT 3
- ingest: Add a back-off state for error scenarios
- Elide tx-meta from transaction data model in db and api. HOT 3
- services/horizon/txsub: submitting transaction with future sequence may result in 60s timeout HOT 1
- Data cannot be presented because it's still being ingested. Please wait for several minutes before trying your request again
- horizon: 500 error in the claimable balance API when claimant, asset and cursor query params used
- services/horizon: deprecate in-memory mode
- Cursor Pagination Issue on Stellar Horizon Server v2.26.1 (also v2.28.1)
- goreplay middleware crashes after few minutes
- Detect Horizon DB query degradation in release candidates
- services/horizon: emit new metrics counters for timeouts HOT 3
- The stellar-horizon program cannot download stellar-history.json HOT 1
- horizon: meta should be returned as null rather than empty when `SKIP_TXMETA` enabled HOT 2
- stellar-horizon startup doesn't look normal HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go.