why can't hook viewDidLoad (UIViewController) ?? about aspects HOT 9 OPEN

Hi everyone,
I made it.
The root cause is that "aspect_isCompatibleBlockSignature" verifies that argument count of blockSignature and methodSignature,and if not matched ,nil returned.
You can see these code :
if (blockSignature.numberOfArguments > methodSignature.numberOfArguments) {
signaturesMatch = NO; //You will go here if wrong block parameters provided as above.
}else {

Now ,we can correct it by changing
[UIViewController aspect_hookSelector:@selector(viewDidLoad)
withOptions:AspectPositionBefore
usingBlock:^(id info, BOOL animated) {
to
[UIViewController aspect_hookSelector:@selector(viewDidLoad)
withOptions:AspectPositionBefore
usingBlock:^(id info) {

It works now for "viewDidLoad".

Hi @steipete,
I suggest to throw an exception here for developers to correct it to right things.

Thanks.

from aspects.

Hi, if you post some code I can help.

from aspects.

Steipete, I create a Category for UIViewcontroller, and have a Class method viewDidloadLogging:

• (void)viewDidloadLogging
  {
  [UIViewController aspect_hookSelector:@selector(viewDidLoad) withOptions:AspectPositionAfter usingBlock:^(idaspectInfo, BOOL animated){
  NSLog(@"View Controller %@ will appear animated: %tu", [aspectInfo.instance class], animated);
  NSLog(@"arguments:%@",[aspectInfo arguments]);
  NSLog(@"originalInvocation:%@",[aspectInfo originalInvocation]);
  } error:NULL];
  }

In my demo AppDelegate,

• (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
  // Override point for customization after application launch.
  [UIViewController viewDidloadLogging];
  return YES;
  }

There are no problems using？

from aspects.

+1

from aspects.

+1's don't help. Somebody who digs in and figures out what fails would help though. Thanks!

from aspects.

So that question answer is what，Steipete？^.^

from aspects.

This is the problem of execution order of [UIViewController viewDidLoad] and [UIViewController viewDidloadLogging]. Please make sure [UIViewController viewDidloadLogging] is invoked before [UIViewController viewDidLoad].

from aspects.

I got the same issue while hooking viewDidLoad selector of UIViewController class.
I can't call the block I provided but "dealloc" is working.

Can you figure out the solution?

Thanks a lot.

The code as following:

• (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
  // Ignore hooks when we are testing.
  if (!NSClassFromString(@"XCTestCase")) {
  [[LogManager sharedInstance] logViewControllerLifeCycle];
  }
  //...other code
  }

• (void)logViewControllerLifeCycle
  {
  [UIViewController aspect_hookSelector:@selector(viewDidLoad)
  withOptions:AspectPositionBefore
  usingBlock:^(id info, BOOL animated) {
  UIViewController *controller = [info instance];
  NSString *key = NSStringFromClass([controller class]);
  NSInteger refCount = [[self.dicViewControllerRefCount objectForKey:key] integerValue];
  refCount++;
  [self.dicViewControllerRefCount setObject:[NSString smc_stringFromInteger:refCount] forKey:key];
  NSLog(@"%s %@ viewDidLoad",FUNCTION,key);
  NSLog(@"%s alloc %@,%ld",FUNCTION,key,refCount);
  } error:NULL];
  //...other code
  }

from aspects.

How can i use AspectPositionInstead option replace viewDidLoad method? Any help would be appreciated.

[MySubViewController aspect_hookSelector:@selector(viewDidLoad) withOptions:AspectPositionInstead usingBlock:^(id info){
//How can i use super here ???
// [super viewDidLoad];
WTSubViewController *vc = (WTSubViewController *)info.instance;
vc.view.backgroundColor = [UIColor blueColor];
} error:NULL];

from aspects.