Code Monkey home page Code Monkey logo

Comments (6)

SteffenMoritz avatar SteffenMoritz commented on May 25, 2024

Thanks a lot for your report! I'll check this. Which ggplot2 version do you have installed?

There has been no ggplot2 cran update recently. Do you use the github develop version or a quite old ggplot2 version?

Would be great, if you could try to have the latest Cran ggplot2 version installed (and loaded) and try to load again.

Best
Steffen

from imputets.

SteffenMoritz avatar SteffenMoritz commented on May 25, 2024

I took another look - after_stat is definitely exported by ggplot2 (current version 3.3.2). Think you have an old ggplot2 version. I'd suggest you update the ggplot version, then it should work again. (if this does not work, just open another issue) Best regards, Steffen

from imputets.

cmohamma avatar cmohamma commented on May 25, 2024

Thanks for the prompt response, you are absolutely correct, older version of ggplot2. Thanks!

from imputets.

cmohamma avatar cmohamma commented on May 25, 2024

Then a feature request, is it possible not to enforce that dependency? Doesnt seem like ggplot2 is a core feature of this package and it might limit the packages use for folks whose hands are tied on the ggplot2 version. Just a thought, thanks so much for a great package!

from imputets.

SteffenMoritz avatar SteffenMoritz commented on May 25, 2024

I gave your idea some thought. What is the reason for you to be tied to an older ggplot2 version? Are you using a server/cluster from your institute/company and you can't update packages there?

Is it possible not to enforce that dependency?

It would be. But, unfortunately all solutions for this issue have some drawbacks I don't like.

I'd expect the problem with older ggplot2 versions on servers/clusters that people can't update will somehow solve itself. In my experience while not being on the latest versions, these clusters are at least updated once in a while.

But what I'll definitely do as a result of your report is to add ggplot2 (≥ 3.3.0) instead of just ggplot to the package dependencies. This way users will get a meaningful error message already during installation. While people probably don't know at all what is wrong from the error message you got, I hope if the message is something like 'ggplot version 3.3.0 needed for installation' they will directly realize how to fix this. (if they can)

from imputets.

SteffenMoritz avatar SteffenMoritz commented on May 25, 2024

As promised, I made a commit today to add ggplot2 (≥ 3.3.0) as requirement to improve this.
Commit: 4573d12
(will also be on CRAN with the next version)

I also added a short shoutout to you in the package NEWS of the new version.
https://github.com/SteffenMoritz/imputeTS/blob/master/NEWS.md

Thanks again for reporting.

from imputets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.