Comments (3)
Hi @stefanobartoletti , thank you for your comment!
It's just that Google Translate is a very good product :)
I would prefer to have a dedicated PR for each proposed service instead of a catch-all.
OK, I will try to create a PR for each feature.
LINE
- I have confirmed that it works correctly on mobile.
- Due to the specifications of LINE, it does not work on a desktop PC.
Bluesky
- Bluesky is a service expected to be alternative Twitter.
- I have confirmed that it works correctly on mobile and desktop PC.
Hatena Bookmark
- Sorry, this is a feature unique to Japan.
- It is a Japanese social bookmarking service.
- In Japan, a website can attract the attention of many people by being shared there.
- I also need it because it is always used by famous blog sites in Japan (Zenn / Qiita).
- Of course, I understand that this is a uniquely Japanese culture.
- And I understand why it was rejected. No worries.
Please note that I was also thinking about including a way to use a customized network,
That's a great feature! I'm looking forward to it :)
And, thank you for your polite and clear comment!
from nuxt-social-share.
@memory-lovers your contributions have been merged, and available in the latest release
from nuxt-social-share.
Hi @memory-lovers, thanks for this, and first of all no worries, your english is very good and the message was clear and polite :)
I had a look at your proposed PR, and it looks good to me, but there are some notes before submitting it:
- I would prefer to have a dedicated PR for each proposed service instead of a catch-all. That way, if some edits or fixing will be required, it will be easier to review and to keep everything in scope.
About the proposed networks:
- Including Line is ok, as it is a widespread messaging app. I'm not using it personally, so I need to ask you to double-check if the URL is working as expected. Then you can proceed with a dedicated PR.
- About Bluesky, I never heard about it before, but judging from the app in the Play Store, it seems to be quite popular. Even here, please check if the share URL is working before opening a PR.
- For Hatena, I am not sure if it is a good fit for inclusion at this moment. As far as I can see, the linked site is only in Japanese (If I am not wrong) and I cannot find some reference in English. I am a bit reluctant to include code where I cannot personally read documentation, even for something as trivial as a share URL: in this context, it will be very hard for me to ensure future maintainability should the API change or if issues arise that need to be addressed. Also, judging by their social accounts, it seems that it is not as widespread as other services included in this module. I'm sorry, but for this specific service at the moment I have to reject the inclusion.
Please note that I was also thinking about including a way to use a customized network, but a the moment it is just an idea. If implemented, I will work on it no sooner than Nuxt 4 will be released. But maybe that could cover your specific need.
Anyway, thanks for this valuable contribution, I really appreciated that you also included links to the apps' docs for reference!
from nuxt-social-share.
Related Issues (9)
- Internal server error: [unimport] failed to find "useRequestURL" imported from "#imports" HOT 5
- Share to Instagram feature HOT 2
- Share to Facebook not working HOT 6
- Fix `useRequestUrl` returning `localhost` on production environment HOT 3
- How to correctly use the useSocialShare composable in nuxt-social-share? HOT 1
- The link with spaces didn't work properly when shared HOT 5
- Dependency Dashboard
- Ability to change the label HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nuxt-social-share.