stefanoallesina / bsd-qbio4 Goto Github PK

Describe the bug
The my_factorial example function in Basic Computing 2 returns incorrect answers if the input is 0 or 1

To Reproduce
my_factorial <- function(a = 6){
if (as.integer(a) != a) {
print("Please enter an integer!")
} else {
tmp <- 1
for (i in 2:a){
tmp <- tmp * i
}
print(paste(a, "! = ", tmp, sep = ""))
}
}

my_factorial(1)
[1] "1! = 2"
my_factorial(0)
[1] "0! = 0"

FIX:
explicitly code in behavior in edge cases

Some changes that would make the reproducibility tutorial flow better:

• Make the "Do one thing at a time" example more relatable and so easier to present (i.e. not involving foos)
• Integrate the ticket generation into the seed section, so that the seed example that people compare is tickets rather than numbers
• Reorganize so that students notice that their edits to make the code more readable (removing magic numbers etc.) would be easier if the copied code were in a function
• Give repos explicit names, e.g. "writings" (not reprodicibility or origin)
• Get rid of single-line if-else statement, as it is unnecessarily confusing
• Include code example of dpois

Use this issue to think about new t-shirt ideas for the next qbio:

1. Escape to Cape Code

Students seem frustrated with the pagination of the workbook.

Let's add some master page numbers throughout, perhaps in addition to the sub-section numbering.

We could alternatively add colored paper or tabs between the sections, but that might be prohibitively expensive to print.

Describe the bug
On keyboards set to a non-English setting, e.g. for Mandarin speaking users, files will be encoded with ASCII, which throws errors unless explicitly stated on some R commands.

To Reproduce
papers <- read.csv("~/BSD-QBio4/tutorials/basic_computing_2/data/citations/nature_neuroscience.csv", stringsAsFactors = FALSE)
papers$TitleLength <- nchar(papers$Title)
Error at [something]:
invalid multibyte string at [something]

FIX:
read csv with explicit file encoding, e.g.
papers <- read.csv("~/BSD-QBio4/tutorials/basic_computing_2/data/citations/nature_neuroscience.csv", stringsAsFactors = FALSE,fileEncoding='ASCII')