Save ~360,000 gas on collection creation by packing 2 pixels into one uint8 about dixel-v2-contract HOT 3 CLOSED

Note: as now the each pixel is uint8, the pixels array accepts values that are bigger than 15.
This means that if the user for example submits a pixel with color value 20, it will succeed in creating the contract, but then the contract will revert when trying to create the metadata or SVG, because there will be an out of bounds exception, as the contract will try to read pallete[20], but pallete only goes up to 15.
So the user would have spent funds for deployment, but the contract will not work.
I am not sure if it worthy to mitigate this by checking the input, as this is unlikely to happen.
But thought it's worth bringing it to your attention.
If we use the packed array method I detailed above, this problem will also be fixed, because then the user couldn't submit a pixel with a color larger than 15.

from dixel-v2-contract.

Implemented in PR #17.

from dixel-v2-contract.

This is brilliant!
Thanks a lot for your effort on looking at the code deeply. 🙏🏻

Your PR is merged and our front-end dev is working on changes on his end.

from dixel-v2-contract.