Comments (2)
sydneyitguy
commented on September 6, 2024
It seems the gas consumption behavior has changed since 0.8.0
Panic exceptions used to use the invalid opcode before Solidity 0.8.0, which consumed all gas available to the call. Exceptions that use require used to consume all gas until before the Metropolis release.
reference
I checked the gas consumption, and they're exactly the same (unless, eth-gas-reporter does not include reverted txs)
However, it seems it's better to use require on external calls according to the official document:
Assert should only be used to test for internal errors, and to check invariants.
So I will probably change few error handlings according to the right usage of each.
Thanks for porting this out!
from dixel-contract.
inmarelibero
commented on September 6, 2024
great! glad to help
from dixel-contract.
Related Issues (11)
- After burning token, original minter continues to receive rewards HOT 1
- Consider removing usage of _msgSender() HOT 2
- airdrop reopening HOT 1
- Reward calculation issue when the same player update in a row HOT 6
- Running all tests not working any more HOT 1
- Reward calculation error - lost rewards HOT 1
- Reward distribution for community audits 💸 HOT 9
- Prevent duplicated pixel params HOT 1
- Prevent updating pixel with the same color HOT 1
- playerWallets can contain duplicate values HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dixel-contract.