Missing connection pooling about discovery HOT 3 CLOSED

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/142381275

The labels on this github issue will be updated when the story is started.

from discovery.

Thanks,
Added code to dispose of HttpClient.
Changes will be included in upcoming 1.0.1 release.
Dave

from discovery.

Hi,

I was talking about something different. In file https://github.com/SteeltoeOSS/Discovery/blob/dev/src/Steeltoe.Discovery.Eureka.Client/Transport/EurekaHttpClient.cs#L597
you're creating new instance of HttpClient, but you're not assigning it to _client field.

It means that you're creating new instance of HttpClient every time you're connecting to Eureka.
Simple assignment

_client = client; 

will solve the issue.

Best Regards,
Roman

from discovery.