Python version not showing on python versions < 3.4 about starship HOT 12 CLOSED

As @matchai said, it's an issue with Python 2 (issue 28160), which was changed in Python 3.4.
This could mean that all Python 3 versions prior to 3.4 might have similar behaviour.

from starship.

@youssefhabri I'm going to try and fix this, as many people still use Python version <= 3.4.

from starship.

@youssefhabri I'm sorry, but I can't reproduce this error ... everything works fine in my terminal:

Are you using the latest code from master? (although I wouldn't think that would affect anything)
@matchai Do you know what's going on?

from starship.

This is likely due to them using a release candidate version of Python. 🤔

from starship.

I've added a dbg! here:

match Command::new("python").arg("--version").output() {
    Ok(output) => {
        dbg!(&output);
        Some(String::from_utf8(output.stdout).unwrap())
    },
    Err(_) => None,
}

and this is what I get:

[src/modules/python.rs:50] &output = Output {
    status: ExitStatus(
        ExitStatus(
            0
        )
    ),
    stdout: "",
    stderr: "Python 2.7.15rc1\n"
}

from starship.

this seems to be only happen with python2, which python is linked to. When I change to python3 it works fine.

from starship.

@youssefhabri that's extremely weird ... not quite sure how to approach this as if the user has both python2 and python3, then if we check both we won't know which version to use.

from starship.

I think we should use whatever is linked to python instead of considering python2 or python3, as it works right now.

from starship.

so this is resolved?

from starship.

The problem seems to be that when python is linked to python2, the version no longer appears.

from starship.

so nothing to be changed at the moment?

from starship.

The issue appears to be that Python 2 logs it's version to stderr but we check stdout. We can retrofit the implementation to work with Python 2.

from starship.