Code Monkey home page Code Monkey logo

Comments (6)

jletey avatar jletey commented on May 18, 2024 3

@matchai I’d prefer for the second option (where we can install via package managers), as users are most familiar with the method and it’s the easiest to install (I like to have everything installed via a package manager ... not having to run scripts)

from starship.

Snuggle avatar Snuggle commented on May 18, 2024 3

Oops, I thought I had responded earlier. We could do both!

Let's say binary is installed, people can either add it themselves or do starship launch to launch with autopilot, we detect what shell is being used and the user and automatically do it, and switch straight into starship. 😊

Maybe even add a quick, cute ASCII animation that shows what's happening.
3... 2... 1... β˜οΈπŸš€

Proposed Steps

  1. Do brew install starship or apt install starship.
  2. Do starship launch.
  3. β˜„οΈ

from starship.

Snuggle avatar Snuggle commented on May 18, 2024 1

@matchai Weirdly, I actually like the first option the most.
A single simple line to add to your config it just works! βœ¨πŸš€

It would feel just... wrong for it to be shipped in omf/fisher/Antigen/Zgen etc. considering it's a system-wide prompt that's globally cross-compatible with any of the three popular shells.

What if I use both Bash, Fish and Zsh and want to have Starship for all three? Or just two of them (Zsh & Fish) to use Starship? What if I install Starship with both omf, fisher and antigen? What happens? D:

This gets incredibly complicated with the other two options but stays super simple with number 1.

from starship.

matchai avatar matchai commented on May 18, 2024

For the v1.0.0 release, I definitely think the first option is the way to go.
It'd be quick to implement and easy to document. The last two options would be more of a v2.0.0 task if we decided to proceed with them.

@Snuggle would you prefer it if we automatically added it to their config files, or asked them to do it themselves after the binary installation?

from starship.

matchai avatar matchai commented on May 18, 2024

Sounds like a good way to get started πŸ‘

Maybe even add a quick, cute ASCII animation that shows what's happening.
3... 2... 1... β˜οΈπŸš€

Yesss! 😍

from starship.

matchai avatar matchai commented on May 18, 2024

After a good amount of testing in basic-init branch, it looks like we can't get enough context from environment variables alone to identify the shell. Fish is able to be reliably identified with $SHELL, but it appears zsh and bash don't export the environment variables that would make them identifiable ($BASH or $SHELL).

Though it's a little more inelegant, my next thought is to do the following:

eval $(SHELL=zsh starship init)

# or 

export STARSHIP_SHELL=zsh
eval $(starship init)

Does anyone have other ideas? πŸ€”

from starship.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.