Starship Prompt confuses bash/zsh cursor location about starship HOT 7 CLOSED

I have tried to solve out this issue by modifying out ANSIString and wrap non-printing character escape for all of ansi-term addition parts in my fork branch-link. I have checked this for bash shell and it seems to work properly for bash not yet tried for zsh. I think there is no issue for fish non printing character count if I am right. If solution is good to go and works for all shell I will create out PR #183

from starship.

Great find, @chipbuster! 😄

Sorry about all the bug reports I've been generating recently!

Don't be! We need hawk-eyed people around to help catch these bugs. I use starship as my daily-driver, but only on Fish. My visibility over these issues is limited. 😅

I'd be curious to find out if this issue occurs on other dynamic colored prompts. I'll be experimenting to see if maybe this is an underlying issue in zsh rather than something to do with the prompt itself. In https://github.com/matchai/spacefish we have had similar issues that were eventually solved with newly added configuration in fish.

the color codes are coming from the ANSI library, and I don't see a way to tell the library to wrap the escape codes in a shell-specific escape sequence.

ansi_term is a pretty light library. If need be, we could create a PR or fork it to add the functionality needed for starship to work correctly.

from starship.

I'd be curious to find out if this issue occurs on other dynamic colored prompts.

By that do you mean any prompt that's dynamically generated or specifically one generated outside the shell?

While searching around, I definitely stumbled over some bugs involving this in the early years of oh-my-zsh and zprezto, but they were almost always solved by proper application of %{ and %} to the prompt generation functions.

from starship.

Seems like this ansi-term issue is due to the same underlying issue (only in bash): ogham/rust-ansi-term#36

from starship.

@iamsauravsharma your solution seems to work fine with zsh, thanks.

from starship.

I'm still experiencing this issue on 0.13.1 with oh-my-zsh:
https://asciinema.org/a/5J7BtDkoMnMDZb7fzNbcZp9Nx

(If I should open a new issue for this, please let me know.)

from starship.

@mozbhearsum Go ahead and open an issue (mostly because it's going to get lost if it stays here--I almost forgot to respond to this).

Does tab-completion appear to work correctly for you or is that broken as well? And is this taking place within a dockerized environment?

from starship.