Code Monkey home page Code Monkey logo

Comments (7)

davidgiven avatar davidgiven commented on June 12, 2024

What's happening is that try_dfs is miscategorising the disk as a SIDES_INTERLEAVED DFS disk, rather than a SIDES_SINGLE one. That's because the heuristic to try and check for an interleaved disk is being spoofed by a completely coincidental piece of data at offset &106 of track 1 which looks like another catalogue header, so it thinks it's a double-sided disk.

I have no idea what can be done about this.

from b-em.

SteveFosdick avatar SteveFosdick commented on June 12, 2024

That's a pity. The only two options that come to mind are to see if there is a more throrough heuristic or to revert to using the file extension.

The reason for going for a heuristic was to deal with the "sequential-sided-disc" format which is also in the wild but uses the same file extension, SSD, as single-sided discs and to deal with the fact that filename extensions have not been assigned to images of discs from non-Acorn DFSes.

I'll check out the documention again.

from b-em.

SteveFosdick avatar SteveFosdick commented on June 12, 2024

Ok, I have come up with an extra couple of tests. In theory, nothing could make a co-incidence impossible but this should make it much less likely. As well as checking that the number of sectors seems to match the new code also checks that the number of directory entries is valid and that the start sector addresses are sorted in descending order. I just need to test it, now.

from b-em.

SteveFosdick avatar SteveFosdick commented on June 12, 2024

The new code correctly detects your mandel SSD. Now to test on some others.

from b-em.

SteveFosdick avatar SteveFosdick commented on June 12, 2024

Ok, I have a fix in branch https://github.com/stardot/b-em/tree/sf/issue63.

from b-em.

SteveFosdick avatar SteveFosdick commented on June 12, 2024

This commit is now in master.

from b-em.

davidgiven avatar davidgiven commented on June 12, 2024

Thanks very much!

from b-em.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.