Code adjustements for W10/MinGW64 build about b-em HOT 5 CLOSED

Hi,

Thanks. Are you able to open a pull-request which looks to address these issues?

from b-em.

Yes I will, but I think we must have a neater solution to the max_allign_t typedef issue. I've forked the repository now and continue from there as per instruction.

Meanwhile, how can I contribute to the wiki? Is appears to be a seperate repository which does not fork and it doesn't allow me to push to the master.

from b-em.

I've opened up the Wiki to edits from any authenticated user. So you should be able to create a new page now.

from b-em.

I think I have a solution to the max_allign_t typedef. It seems this was introduced in C11 and for the previous MingW version of gcc that is not the default standard level meaning it is undefined and tsearch.c has to include its own declaration. The MingW64 version of gcc by default uses gnu11 as its standard i.e. everything in C11 + GNU extensions so that typedef will then be defined. So what I think that means is that instead of testing OS or compiler we should test the C standard version to work out whether to include it, i.e. instead of:

#ifndef __CLANG_MAX_ALIGN_T_DEFINED
typedef long double max_align_t;
#endif

we should have:

#if __STDC_VERSION__ < 201112
typedef long double max_align_t;
#endif

from b-em.

Dominic Beasley is current working on B-Em in Visual Studio so I am assuming it compiles fine now.

from b-em.